Page MenuHomePhabricator

rfoos (Rick Foos)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2013, 8:53 AM (310 w, 1 d)

Recent Activity

Aug 6 2015

rfoos abandoned D6909: Add cmake flags to disable LLD and LLDB from build..

Impacts existing flags for llvm, wrong direction.

Aug 6 2015, 10:51 AM

Apr 29 2015

rfoos committed rL236173: XFAIL Hexagon until more codegen in place..
XFAIL Hexagon until more codegen in place.
Apr 29 2015, 3:58 PM
rfoos closed D9356: XFAIL Hexagon until more codegen in place..
Apr 29 2015, 3:57 PM
rfoos accepted D9356: XFAIL Hexagon until more codegen in place..
Apr 29 2015, 3:56 PM
rfoos added a reviewer for D9356: XFAIL Hexagon until more codegen in place.: colinl.
Apr 29 2015, 3:49 PM
rfoos retitled D9356: XFAIL Hexagon until more codegen in place. from to XFAIL Hexagon until more codegen in place..
Apr 29 2015, 3:46 PM

Apr 21 2015

rfoos committed rL235449: [zorg] LitTestCommand aborts if Verbose log line is not preceded by a valid….
[zorg] LitTestCommand aborts if Verbose log line is not preceded by a valid…
Apr 21 2015, 3:29 PM · Restricted Project
rfoos closed D9091: [zorg] LitTestCommand aborts if Verbose log line is not preceded by a valid test status line..
Apr 21 2015, 3:19 PM · Restricted Project
rfoos updated the diff for D9091: [zorg] LitTestCommand aborts if Verbose log line is not preceded by a valid test status line..

Changed testInfoFinished so normal case is first.

Apr 21 2015, 3:15 PM · Restricted Project

Apr 17 2015

rfoos updated D9091: [zorg] LitTestCommand aborts if Verbose log line is not preceded by a valid test status line..
Apr 17 2015, 4:21 PM · Restricted Project
rfoos added a reviewer for D9091: [zorg] LitTestCommand aborts if Verbose log line is not preceded by a valid test status line.: gkistanova.
Apr 17 2015, 4:19 PM · Restricted Project
rfoos retitled D9091: [zorg] LitTestCommand aborts if Verbose log line is not preceded by a valid test status line. from to [zorg] LitTestCommand aborts if Verbose log line is not preceded by a valid test status line..
Apr 17 2015, 4:17 PM · Restricted Project

Apr 15 2015

rfoos committed rL235045: [zorg] Fix LitTestCommand unexpected test result when TIMEOUT is returned..
[zorg] Fix LitTestCommand unexpected test result when TIMEOUT is returned.
Apr 15 2015, 2:45 PM · Restricted Project
rfoos closed D9022: [zorg] Fix LitTestCommand unexpected test result when TIMEOUT is returned..
Apr 15 2015, 2:45 PM · Restricted Project
rfoos added a comment to D9022: [zorg] Fix LitTestCommand unexpected test result when TIMEOUT is returned..

So this should be clear to merge now.

Apr 15 2015, 8:10 AM · Restricted Project

Apr 14 2015

rfoos added a comment to D9022: [zorg] Fix LitTestCommand unexpected test result when TIMEOUT is returned..

svn r230575 via git...

Apr 14 2015, 3:15 PM · Restricted Project
rfoos updated D9022: [zorg] Fix LitTestCommand unexpected test result when TIMEOUT is returned..
Apr 14 2015, 2:32 PM · Restricted Project
rfoos updated D9022: [zorg] Fix LitTestCommand unexpected test result when TIMEOUT is returned..
Apr 14 2015, 2:27 PM · Restricted Project
rfoos retitled D9022: [zorg] Fix LitTestCommand unexpected test result when TIMEOUT is returned. from to [zorg] Fix LitTestCommand unexpected test result when TIMEOUT is returned..
Apr 14 2015, 2:20 PM · Restricted Project

Apr 10 2015

rfoos abandoned D6867: [zorg] Windows/Linux CMake builders for Hexagon using common getClangCMakeBuildFactory.

Superseded by D6866

Apr 10 2015, 9:09 AM · Restricted Project

Apr 8 2015

rfoos committed rL234454: [zorg] Lit parser should ignore leading whitespace in log file..
[zorg] Lit parser should ignore leading whitespace in log file.
Apr 8 2015, 4:26 PM · Restricted Project
rfoos closed D8878: [zorg] Lit parser should ignore leading whitespace in log file..
Apr 8 2015, 4:25 PM · Restricted Project
rfoos added inline comments to D8878: [zorg] Lit parser should ignore leading whitespace in log file..
Apr 8 2015, 11:43 AM · Restricted Project

Apr 7 2015

rfoos retitled D8878: [zorg] Lit parser should ignore leading whitespace in log file. from Lit parser should ignore leading whitespace in log file. to [zorg] Lit parser should ignore leading whitespace in log file..
Apr 7 2015, 1:00 PM · Restricted Project
rfoos added a reviewer for D8878: [zorg] Lit parser should ignore leading whitespace in log file.: gkistanova.
Apr 7 2015, 12:49 PM · Restricted Project
rfoos updated the diff for D8878: [zorg] Lit parser should ignore leading whitespace in log file..

Drop file not part of change.

Apr 7 2015, 12:48 PM · Restricted Project
rfoos retitled D8878: [zorg] Lit parser should ignore leading whitespace in log file. from to Lit parser should ignore leading whitespace in log file..
Apr 7 2015, 12:46 PM · Restricted Project

Mar 10 2015

rfoos abandoned D5588: [zorg] Add options allowing MSVC builds with Clang Cmake Build Factory..

Replaced by D6866

Mar 10 2015, 9:25 AM

Mar 4 2015

rfoos updated subscribers of D8044: Temporary XFAILs for Hexagon.
Mar 4 2015, 4:03 PM
rfoos committed rL231318: Temporary XFAILs for Hexagon.
Temporary XFAILs for Hexagon
Mar 4 2015, 3:43 PM
rfoos closed D8044: Temporary XFAILs for Hexagon.
Mar 4 2015, 3:42 PM
rfoos closed D7149: [zorg] Rev2: Fix get slave environment in LLDB Windows builder..
Mar 4 2015, 9:54 AM · Restricted Project
rfoos added a comment to D8044: Temporary XFAILs for Hexagon.

Not sure who approves/cares about minor updates to clang tests.

Mar 4 2015, 9:51 AM
rfoos retitled D8044: Temporary XFAILs for Hexagon from Temporary XFAILs. to Temporary XFAILs for Hexagon.
Mar 4 2015, 9:49 AM

Mar 3 2015

rfoos retitled D8044: Temporary XFAILs for Hexagon from to Temporary XFAILs..
Mar 3 2015, 2:37 PM
rfoos added a comment to D6866: [zorg] Support Windows/Linux Clang CMake builds with unified builder..

Yes, I've been tied up with several things.

Mar 3 2015, 11:05 AM · Restricted Project

Feb 9 2015

rfoos committed rL228597: [zorg] Rev2: Fix get slave environment in LLDB Windows builder..
[zorg] Rev2: Fix get slave environment in LLDB Windows builder.
Feb 9 2015, 11:54 AM
rfoos added a comment to D7149: [zorg] Rev2: Fix get slave environment in LLDB Windows builder..

Yes, NinjaCommand looks interesting.

Feb 9 2015, 11:24 AM · Restricted Project

Feb 6 2015

rfoos updated the diff for D7149: [zorg] Rev2: Fix get slave environment in LLDB Windows builder..

vs_common -> vs
ignoreFail: remove halt and warn OnFailure.
default is no install or test steps.

Feb 6 2015, 5:50 PM · Restricted Project
rfoos planned changes to D7149: [zorg] Rev2: Fix get slave environment in LLDB Windows builder..

Testing now.

Feb 6 2015, 5:20 PM · Restricted Project
rfoos closed D6962: [zorg] Add windows lldb test builder to zorg .
Feb 6 2015, 5:07 PM · Restricted Project
rfoos closed D7305: [zorg] Add LLDB x86_64 Ubuntu 14.10 builder..
Feb 6 2015, 5:06 PM · Restricted Project

Feb 3 2015

rfoos accepted D7305: [zorg] Add LLDB x86_64 Ubuntu 14.10 builder..

[zorg] r228072 - [zorg] Add LLDB x86_64 Ubuntu 14.10 builder.

Feb 3 2015, 4:45 PM · Restricted Project
rfoos committed rL228072: [zorg] Add LLDB x86_64 Ubuntu 14.10 builder..
[zorg] Add LLDB x86_64 Ubuntu 14.10 builder.
Feb 3 2015, 3:52 PM

Jan 30 2015

rfoos added a comment to D7149: [zorg] Rev2: Fix get slave environment in LLDB Windows builder..

Yes, the three comments are good to implement.

Jan 30 2015, 5:43 PM · Restricted Project
rfoos retitled D7305: [zorg] Add LLDB x86_64 Ubuntu 14.10 builder. from to [zorg] Add LLDB x86_64 Ubuntu 14.10 builder..
Jan 30 2015, 2:49 PM · Restricted Project

Jan 26 2015

rfoos planned changes to D6866: [zorg] Support Windows/Linux Clang CMake builds with unified builder..

Thanks for looking at it!

Jan 26 2015, 5:13 PM · Restricted Project

Jan 23 2015

rfoos updated the diff for D6866: [zorg] Support Windows/Linux Clang CMake builds with unified builder..

Incorporated all comments.
llvmGetSource direct calls from source tree dictionary.
Added user environment variables.
Fixed ignore fail
Added install for use Previous built compiler.
Windows escaping fixes to built compiler path.

Jan 23 2015, 11:23 AM · Restricted Project
rfoos closed D7077: [zorg] Rev1: Fix get slave environment in LLDB Windows builder..

r226700, and r226731

Jan 23 2015, 8:40 AM · Restricted Project
rfoos retitled D7149: [zorg] Rev2: Fix get slave environment in LLDB Windows builder. from to [zorg] Rev2: Fix get slave environment in LLDB Windows builder..
Jan 23 2015, 8:29 AM · Restricted Project
rfoos added a comment to D7017: [zorg] Fix get slave environment in LLDB Windows builder..

Something like that.

Jan 23 2015, 8:06 AM · Restricted Project

Jan 22 2015

rfoos added a comment to D7017: [zorg] Fix get slave environment in LLDB Windows builder..

Hi Zachary,

Jan 22 2015, 10:23 PM · Restricted Project
rfoos planned changes to D6866: [zorg] Support Windows/Linux Clang CMake builds with unified builder..

I have the updates done, and now testing.

Jan 22 2015, 2:22 PM · Restricted Project

Jan 21 2015

rfoos added inline comments to D6866: [zorg] Support Windows/Linux Clang CMake builds with unified builder..
Jan 21 2015, 4:23 PM · Restricted Project
rfoos committed rL226731: [zorg] Fix ignorefail in r226700.
[zorg] Fix ignorefail in r226700
Jan 21 2015, 2:56 PM
rfoos committed rL226700: [zorg] Rev1: Fix get slave environment in LLDB Windows builder..
[zorg] Rev1: Fix get slave environment in LLDB Windows builder.
Jan 21 2015, 12:59 PM
rfoos accepted D7077: [zorg] Rev1: Fix get slave environment in LLDB Windows builder..

Ready to go.

Jan 21 2015, 12:35 PM · Restricted Project
rfoos added a reviewer for D7077: [zorg] Rev1: Fix get slave environment in LLDB Windows builder.: zturner.
Jan 21 2015, 11:16 AM · Restricted Project
rfoos updated the diff for D7077: [zorg] Rev1: Fix get slave environment in LLDB Windows builder..

Moved comments to getLLDBSource.

Jan 21 2015, 11:15 AM · Restricted Project
rfoos planned changes to D7077: [zorg] Rev1: Fix get slave environment in LLDB Windows builder..

The changes are reasonably small. I'll get this back up, and would like to go live soon.

Jan 21 2015, 9:16 AM · Restricted Project
rfoos updated the diff for D6866: [zorg] Support Windows/Linux Clang CMake builds with unified builder..

SVN/Git checkout using list of projects [svn-llvm, svn-clang]

Jan 21 2015, 8:34 AM · Restricted Project

Jan 20 2015

rfoos added a comment to D7017: [zorg] Fix get slave environment in LLDB Windows builder..

Sorry about RemoveDirectory. It was part of some internal modifications.

Jan 20 2015, 5:49 PM · Restricted Project
rfoos abandoned D7017: [zorg] Fix get slave environment in LLDB Windows builder..

Superceeded by:
http://reviews.llvm.org/D7077

Jan 20 2015, 5:46 PM · Restricted Project
rfoos updated subscribers of D7077: [zorg] Rev1: Fix get slave environment in LLDB Windows builder..
Jan 20 2015, 5:45 PM · Restricted Project
rfoos retitled D7077: [zorg] Rev1: Fix get slave environment in LLDB Windows builder. from to [zorg] Rev1: Fix get slave environment in LLDB Windows builder..
Jan 20 2015, 5:44 PM · Restricted Project
rfoos updated the diff for D7017: [zorg] Fix get slave environment in LLDB Windows builder..

Duplicate imports removed.
check-lldb step added to debug test suite. flunkOnFailure True to ignore errors.
Install step added to test final executable packaging with Python.

Jan 20 2015, 3:08 PM · Restricted Project
rfoos planned changes to D7017: [zorg] Fix get slave environment in LLDB Windows builder..

Planned Changes completed.

Jan 20 2015, 3:03 PM · Restricted Project

Jan 19 2015

rfoos added inline comments to D6866: [zorg] Support Windows/Linux Clang CMake builds with unified builder..
Jan 19 2015, 12:12 PM · Restricted Project
rfoos added inline comments to D7017: [zorg] Fix get slave environment in LLDB Windows builder..
Jan 19 2015, 11:07 AM · Restricted Project

Jan 16 2015

rfoos added inline comments to D7017: [zorg] Fix get slave environment in LLDB Windows builder..
Jan 16 2015, 11:21 AM · Restricted Project
rfoos retitled D7017: [zorg] Fix get slave environment in LLDB Windows builder. from to [zorg] Fix get slave environment in LLDB Windows builder..
Jan 16 2015, 11:19 AM · Restricted Project
rfoos planned changes to D6909: Add cmake flags to disable LLD and LLDB from build..

Bob's comments point out that this may not be the right direction.

Jan 16 2015, 9:15 AM

Jan 15 2015

rfoos added inline comments to D6866: [zorg] Support Windows/Linux Clang CMake builds with unified builder..
Jan 15 2015, 3:11 PM · Restricted Project

Jan 14 2015

rfoos committed rL226066: [zorg] Add windows lldb test builder to zorg..
[zorg] Add windows lldb test builder to zorg.
Jan 14 2015, 4:48 PM

Jan 13 2015

rfoos retitled D6962: [zorg] Add windows lldb test builder to zorg from to [zorg] Add windows lldb test builder to zorg .
Jan 13 2015, 5:51 PM · Restricted Project

Jan 12 2015

rfoos added a comment to D6909: Add cmake flags to disable LLD and LLDB from build..

Hi Bob,
I was adding these following the WITH_POLLY model and hoping the external projects macros would take care of everything.

Jan 12 2015, 11:49 AM

Jan 9 2015

rfoos added a comment to D6909: Add cmake flags to disable LLD and LLDB from build..

Lol, I thought you were going to bring up autoconf :-)

Jan 9 2015, 4:21 PM
rfoos updated D6909: Add cmake flags to disable LLD and LLDB from build..
Jan 9 2015, 3:51 PM
rfoos retitled D6909: Add cmake flags to disable LLD and LLDB from build. from to Add cmake flags to disable LLD and LLDB from build..
Jan 9 2015, 3:49 PM
rfoos added inline comments to D6867: [zorg] Windows/Linux CMake builders for Hexagon using common getClangCMakeBuildFactory.
Jan 9 2015, 1:46 PM · Restricted Project
rfoos added a comment to D6866: [zorg] Support Windows/Linux Clang CMake builds with unified builder..

I completely agree with several other testers.

Jan 9 2015, 10:13 AM · Restricted Project
rfoos added inline comments to D6867: [zorg] Windows/Linux CMake builders for Hexagon using common getClangCMakeBuildFactory.
Jan 9 2015, 10:09 AM · Restricted Project

Jan 8 2015

rfoos planned changes to D6866: [zorg] Support Windows/Linux Clang CMake builds with unified builder..
Jan 8 2015, 8:20 AM · Restricted Project

Jan 7 2015

rfoos added inline comments to D6745: Create an experimental Windows LLDB Builder.
Jan 7 2015, 3:37 PM
rfoos added inline comments to D6745: Create an experimental Windows LLDB Builder.
Jan 7 2015, 2:29 PM
rfoos added inline comments to D6745: Create an experimental Windows LLDB Builder.
Jan 7 2015, 1:21 PM
rfoos retitled D6867: [zorg] Windows/Linux CMake builders for Hexagon using common getClangCMakeBuildFactory from Windows/Linux CMake builders for Hexagon using common getClangCMakeBuildFactory to [zorg] Windows/Linux CMake builders for Hexagon using common getClangCMakeBuildFactory.
Jan 7 2015, 9:22 AM · Restricted Project
rfoos retitled D6866: [zorg] Support Windows/Linux Clang CMake builds with unified builder. from Support Windows/Linux Clang CMake builds with unified builder. to [zorg] Support Windows/Linux Clang CMake builds with unified builder..
Jan 7 2015, 9:22 AM · Restricted Project
rfoos retitled D6867: [zorg] Windows/Linux CMake builders for Hexagon using common getClangCMakeBuildFactory from to Windows/Linux CMake builders for Hexagon using common getClangCMakeBuildFactory.
Jan 7 2015, 8:44 AM · Restricted Project
rfoos updated subscribers of D6866: [zorg] Support Windows/Linux Clang CMake builds with unified builder..
Jan 7 2015, 8:40 AM · Restricted Project
rfoos retitled D6866: [zorg] Support Windows/Linux Clang CMake builds with unified builder. from to Support Windows/Linux Clang CMake builds with unified builder..
Jan 7 2015, 8:38 AM · Restricted Project

Dec 18 2014

rfoos added inline comments to D5588: [zorg] Add options allowing MSVC builds with Clang Cmake Build Factory..
Dec 18 2014, 4:39 PM

Dec 17 2014

rfoos added inline comments to D5588: [zorg] Add options allowing MSVC builds with Clang Cmake Build Factory..
Dec 17 2014, 4:29 PM
rfoos added a comment to D5588: [zorg] Add options allowing MSVC builds with Clang Cmake Build Factory..

I'm using MSBuild on MSVC Windows to be conservative.

Dec 17 2014, 1:29 PM
rfoos added a comment to D5588: [zorg] Add options allowing MSVC builds with Clang Cmake Build Factory..

Apologies, I've been out for a bit. It looks like the slave environment capture has been merged. I'll address the rest of the issues today.

Dec 17 2014, 10:12 AM
rfoos added a comment to D6702: Work around for Visual Studio 2013 compiler crash.

I'm having these problems on MSVC 13 update 3 with a 64 bit build.

Dec 17 2014, 9:31 AM

Oct 2 2014

rfoos added a comment to D5588: [zorg] Add options allowing MSVC builds with Clang Cmake Build Factory..

Yes, I'll attach them, and hopefully not spam everyone.

Oct 2 2014, 3:36 PM
rfoos updated subscribers of D5588: [zorg] Add options allowing MSVC builds with Clang Cmake Build Factory..
Oct 2 2014, 2:36 PM
rfoos retitled D5588: [zorg] Add options allowing MSVC builds with Clang Cmake Build Factory. from to [zorg] Add options allowing MSVC builds with Clang Cmake Build Factory..
Oct 2 2014, 2:35 PM

Sep 22 2014

rfoos abandoned D5396: New MSVC 2013 builders for Clang and LLDB..

Merging this into Renato's clang cmake builder.

Sep 22 2014, 1:17 PM