[lldb] [Process/NetBSD] Use PT_STOP to stop the process

[labath]

Does this have any functional difference that would be useful to test?

[mgorny]

Not that I know of. The main difference is how it behaves on a stopped process but I don't think we're ever issuing it on one.

[labath]

lgtm

lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h

public:
   Status Resume(const ResumeActionList &resume_actions) override;
 
   Status Halt() override;
 
   Status Detach() override;
 
   Status Signal(int signo) override;
 
+  Status Interrupt() override;
+
   Status Kill() override;
 
   Status GetMemoryRegionInfo(lldb::addr_t load_addr,
                              MemoryRegionInfo &range_info) override;
 
   Status ReadMemory(lldb::addr_t addr, void *buf, size_t size,
                     size_t &bytes_read) override;
 

lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp

return Status("NativeProcessNetBSD::%s (): unexpected state %s specified "
                   __FUNCTION__, StateAsCString(action->state), GetID(),
                   thread->GetID());
   }
 
   return Status();
 }
 
 Status NativeProcessNetBSD::Halt() {
-  Status error;
-
-  if (kill(GetID(), SIGSTOP) != 0)
-    error.SetErrorToErrno();
-
-  return error;
+  return PtraceWrapper(PT_STOP, GetID());
 }
 
 Status NativeProcessNetBSD::Detach() {
   Status error;
 
   // Stop monitoring the inferior.
   m_sigchld_handle.reset();
 
   // Tell ptrace to detach from the process.
   if (GetID() == LLDB_INVALID_PROCESS_ID)
     return error;
 
   return PtraceWrapper(PT_DETACH, GetID());
 }
 
 Status NativeProcessNetBSD::Signal(int signo) {
   Status error;
 
   if (kill(GetID(), signo))
     error.SetErrorToErrno();
 
   return error;
 }
 
+Status NativeProcessNetBSD::Interrupt() {
+  return PtraceWrapper(PT_STOP, GetID());
+}
+
 Status NativeProcessNetBSD::Kill() {
   Log *log(ProcessPOSIXLog::GetLogIfAllCategoriesSet(POSIX_LOG_PROCESS));
   LLDB_LOG(log, "pid {0}", GetID());
 
   Status error;
 
   switch (m_state) {
   case StateType::eStateInvalid: