This is an archive of the discontinued LLVM Phabricator instance.

Differential D70013

[JumpThreading] Fix a comment typo (NFC)
ClosedPublic

Authored by kazu on Nov 8 2019, 9:28 AM.

Details

Reviewers
kazu
Commits
rG9aff5e1c1884: [JumpThreading] Fix a comment typo (NFC)

Diff Detail

Event Timeline

kazu created this revision.Nov 8 2019, 9:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 8 2019, 9:28 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
kazu accepted this revision.Nov 8 2019, 9:29 AM
This revision is now accepted and ready to land.Nov 8 2019, 9:29 AM
Harbormaster completed remote builds in B40695: Diff 228475.Nov 8 2019, 9:30 AM
Closed by commit rG9aff5e1c1884: [JumpThreading] Fix a comment typo (NFC) (authored by kazu). · Explain WhyNov 8 2019, 9:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Transforms/
Scalar/
2 lines

Diff 228478

llvm/lib/Transforms/Scalar/JumpThreading.cpp

Show First 20 Lines • Show All 1,891 Lines • ▼ Show 20 Linesbool JumpThreadingPass::MaybeMergeBasicBlockIntoOnlyPred(BasicBlock *BB) {
// If SinglePred was a loop header, BB becomes one. // If SinglePred was a loop header, BB becomes one.
if (LoopHeaders.erase(SinglePred)) if (LoopHeaders.erase(SinglePred))
LoopHeaders.insert(BB); LoopHeaders.insert(BB);
LVI->eraseBlock(SinglePred); LVI->eraseBlock(SinglePred);
MergeBasicBlockIntoOnlyPred(BB, DTU); MergeBasicBlockIntoOnlyPred(BB, DTU);
// Now that BB is merged into SinglePred (i.e. SinglePred Code followed by // Now that BB is merged into SinglePred (i.e. SinglePred code followed by
// BB code within one basic block `BB`), we need to invalidate the LVI // BB code within one basic block `BB`), we need to invalidate the LVI
// information associated with BB, because the LVI information need not be // information associated with BB, because the LVI information need not be
// true for all of BB after the merge. For example, // true for all of BB after the merge. For example,
// Before the merge, LVI info and code is as follows: // Before the merge, LVI info and code is as follows:
// SinglePred: <LVI info1 for %p val> // SinglePred: <LVI info1 for %p val>
// %y = use of %p // %y = use of %p
// call @exit() // need not transfer execution to successor. // call @exit() // need not transfer execution to successor.
// assume(%p) // from this point on %p is true // assume(%p) // from this point on %p is true
▲ Show 20 Lines • Show All 842 Lines • Show Last 20 Lines