This is an archive of the discontinued LLVM Phabricator instance.

[libc++abi] Add support for cross compiling.
ClosedPublic

Authored by danalbert on Jan 14 2015, 6:29 PM.

Diff Detail

Event Timeline

danalbert updated this revision to Diff 18207.Jan 14 2015, 6:29 PM
danalbert retitled this revision from to [libc++abi] Add support for cross compiling..
danalbert updated this object.
danalbert edited the test plan for this revision. (Show Details)
danalbert added reviewers: jroelofs, EricWF.
danalbert set the repository for this revision to rL LLVM.
danalbert added a subscriber: Unknown Object (MLST).

This will need to be revisited to inform LIT once http://reviews.llvm.org/D6985 lands.

CMakeLists.txt
140

Same comments from http://reviews.llvm.org/D6990 apply.

danalbert updated this revision to Diff 18277.Jan 15 2015, 4:29 PM

Remove LIBCXXABI_CROSSCOMPILING. Same reasoning as D6990.

jroelofs accepted this revision.Jan 15 2015, 4:39 PM
jroelofs edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jan 15 2015, 4:39 PM
danalbert updated this revision to Diff 18282.Jan 15 2015, 4:51 PM
danalbert edited edge metadata.

Use set() instead of option() for string options.

danalbert closed this revision.Jan 15 2015, 4:53 PM