This is an archive of the discontinued LLVM Phabricator instance.

Differential D69724

[dexter] Remove lit check for python 3
ClosedPublic

Authored by rnk on Nov 1 2019, 11:36 AM.

Details

Reviewers
jmorse
Commits
rG7035ea6e3e43: [dexter] Remove lit check for python 3
Summary

This is checking the version of Python used to run lit, which is not
necessarily the same as the version used to run the dexter tests. If
the tests are run via the build/bin/llvm-lit[.py] helper script, then
that is likely to pick up whatever version of Python is on PATH.
Conventionally, this will find Python 2. CMake already checks that
Python 3 is in use and puts the path to it in the lit site config, so
this check is redundant, and Python 3 will ultimately be used to run
dexter.

Diff Detail

Event Timeline

rnk created this revision.Nov 1 2019, 11:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2019, 11:36 AM
Harbormaster completed remote builds in B40412: Diff 227496.Nov 1 2019, 11:36 AM
jmorse accepted this revision.Nov 4 2019, 1:07 AM

LGTM

This revision is now accepted and ready to land.Nov 4 2019, 1:07 AM
Closed by commit rG7035ea6e3e43: [dexter] Remove lit check for python 3 (authored by rnk). · Explain WhyNov 5 2019, 10:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
debuginfo-tests/
dexter/
feature_tests/
6 lines

Diff 227925

debuginfo-tests/dexter/feature_tests/lit.local.cfg

config.name = "DExTer feature tests" config.name = "DExTer feature tests"
config.suffixes = ['.cpp', '.c', '.test'] config.suffixes = ['.cpp', '.c', '.test']
# Dexter requires python3
import sys
if sys.version_info.major < 3:
config.unsupported = True