This is an archive of the discontinued LLVM Phabricator instance.

[dexter] Remove lit check for python 3
ClosedPublic

Authored by rnk on Nov 1 2019, 11:36 AM.

Details

Summary

This is checking the version of Python used to run lit, which is not
necessarily the same as the version used to run the dexter tests. If
the tests are run via the build/bin/llvm-lit[.py] helper script, then
that is likely to pick up whatever version of Python is on PATH.
Conventionally, this will find Python 2. CMake already checks that
Python 3 is in use and puts the path to it in the lit site config, so
this check is redundant, and Python 3 will ultimately be used to run
dexter.

Diff Detail

Event Timeline

rnk created this revision.Nov 1 2019, 11:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 1 2019, 11:36 AM
jmorse accepted this revision.Nov 4 2019, 1:07 AM

LGTM

This revision is now accepted and ready to land.Nov 4 2019, 1:07 AM
This revision was automatically updated to reflect the committed changes.