This is an archive of the discontinued LLVM Phabricator instance.

TableGen: Use enum names in composeSubRegIndices table
ClosedPublic

Authored by arsenm on Oct 25 2019, 2:04 PM.

Reviewers

qcolombet
MatzeB

Summary

I'm not sure why this is using the raw enum value. This makes reading the generated table comprehensible.

This revision is now accepted and ready to land.Oct 25 2019, 2:52 PM

525169efd1eefe044406bd41b3159359e0cabd4e

Path

Size

llvm/

utils/

TableGen/

2 lines

Show First 20 Lines • Show All 736 Lines • ▼ Show 20 Lines	RegisterInfoEmitter::emitComposeSubRegIndices(raw_ostream &OS,

// Output the rows.		// Output the rows.
OS << " static const " << getMinimalTypeForRange(SubRegIndicesSize + 1, 32)		OS << " static const " << getMinimalTypeForRange(SubRegIndicesSize + 1, 32)
<< " Rows[" << Rows.size() << "][" << SubRegIndicesSize << "] = {\n";		<< " Rows[" << Rows.size() << "][" << SubRegIndicesSize << "] = {\n";
for (unsigned r = 0, re = Rows.size(); r != re; ++r) {		for (unsigned r = 0, re = Rows.size(); r != re; ++r) {
OS << " { ";		OS << " { ";
for (unsigned i = 0, e = SubRegIndicesSize; i != e; ++i)		for (unsigned i = 0, e = SubRegIndicesSize; i != e; ++i)
if (Rows[r][i])		if (Rows[r][i])
OS << Rows[r][i]->EnumValue << ", ";		OS << Rows[r][i]->getQualifiedName() << ", ";
else		else
OS << "0, ";		OS << "0, ";
OS << "},\n";		OS << "},\n";
}		}
OS << " };\n\n";		OS << " };\n\n";

OS << " --IdxA; assert(IdxA < " << SubRegIndicesSize << ");\n"		OS << " --IdxA; assert(IdxA < " << SubRegIndicesSize << ");\n"
<< " --IdxB; assert(IdxB < " << SubRegIndicesSize << ");\n";		<< " --IdxB; assert(IdxB < " << SubRegIndicesSize << ");\n";
▲ Show 20 Lines • Show All 928 Lines • Show Last 20 Lines