[lldb] Fix broken -D option for breakpoint set command

[poya]

Summary

BreakpointDummyOptionGroup was using g_breakpoint_modify_options rather than g_breakpoint_dummy_options causing the -D option for breakpoint set command to be incorrectly parsed.

[jingham]

Ack, yes. That's definitely wrong. Could you write a test for this to make sure we don't break it in the future. This should fail if you make one target, set a breakpoint with the -D option, then make a second target and check that it has the breakpoint, so it should be pretty easy to write the test? That way I won't break it again...

[poya]

Sure, I'll try to add a test in test/Shell/Breakpoint once I get the tests up and running on my machine.

[poya]

Added a test

[jingham]

LGTM, thanks!

[poya]

No commit access, so would need some assistance getting this change into the repo.

[jingham]

In D69425#1731155, @poya wrote:

No commit access, so would need some assistance getting this change into the repo.

I pushed this (f1539b9db39a59a5e50c065c39e491ba4f890377).

lldb/source/Commands/CommandObjectBreakpoint.cpp

public:
   llvm::ArrayRef<OptionDefinition> GetDefinitions() override {
     return llvm::makeArrayRef(g_breakpoint_dummy_options);
   }
 
   Status SetOptionValue(uint32_t option_idx, llvm::StringRef option_arg,
                         ExecutionContext *execution_context) override {
     Status error;
     const int short_option =
-        g_breakpoint_modify_options[option_idx].short_option;
+        g_breakpoint_dummy_options[option_idx].short_option;
 
     switch (short_option) {
     case 'D':
       m_use_dummy = true;
       break;
     default:
       llvm_unreachable("Unimplemented option");
     }

lldb/test/Shell/Breakpoint/Inputs/dummy-target.c

+int main() { return 0; }

lldb/test/Shell/Breakpoint/dummy-target.test

+# RUN: mkdir -p %t
+# RUN: cd %t
+# RUN: %build %p/Inputs/dummy-target.c -o dummy.out
+# RUN: %lldb -b -s %s dummy.out | FileCheck %s
+
+breakpoint set -D -n main
+# CHECK: Breakpoint {{[0-9]}}: no locations (pending).
+# CHECK: Breakpoint set in dummy target
+
+breakpoint list
+# CHECK: No breakpoints currently set
+
+breakpoint list -D
+# CHECK: name = 'main', locations = 0 (pending)
+
+target delete
+# CHECK: 1 targets deleted
+
+target create dummy.out
+# CHECK: Current executable set to {{.*}}dummy.out
+
+breakpoint list
+# CHECK: name = 'main', locations = {{[1-9]}}