Page MenuHomePhabricator

[Sema] Make helper in TreeTransform.h 'inline' instead of 'static'. NFC
ClosedPublic

Authored by ilya-biryukov on Mon, Oct 21, 2:03 AM.

Details

Summary

There seems to be no evidence that having internal linkage for the function
was intentional. Since 'static' functions are normally used only in .cpp
files, using 'inline' in the header file is more appropriate.

Diff Detail

Event Timeline

ilya-biryukov created this revision.Mon, Oct 21, 2:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Oct 21, 2:03 AM
ilya-biryukov retitled this revision from [Sema] Make helper in Sema.h 'inline' instead of 'static' to [Sema] Make helper in TreeTransform.h 'inline' instead of 'static'. NFC.Mon, Oct 21, 2:04 AM

Build result: fail - 33519 tests passed, 1 failed and 464 were skipped.

failed: LLVM.tools/llvm-ar/mri-utf8.test

Log files: cmake-log.txt, ninja_check_all-log.txt, CMakeCache.txt

Anastasia accepted this revision.Fri, Nov 1, 4:11 AM

I agree. LGTM! Thanks!

This revision is now accepted and ready to land.Fri, Nov 1, 4:11 AM
This revision was automatically updated to reflect the committed changes.