This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] CloexecDupCheck: Always pass the third argument
Needs ReviewPublic

Authored by sgallagher on Oct 17 2019, 1:46 PM.

Details

Reviewers
llvm-commits
Summary

When running valgrind, the third argument is read implicitly from
the stack, resulting in an EINVAL return from the fcntl(). We should
explicitly be setting the third argument to zero to ensure that we
don't break valgrind.

Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>

Diff Detail

Repository
rL LLVM

Event Timeline

sgallagher created this revision.Oct 17 2019, 1:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2019, 1:46 PM
MyDeveloperDay retitled this revision from CloexecDupCheck: Always pass the third argument to [clang-tidy] CloexecDupCheck: Always pass the third argument.Dec 5 2019, 2:25 AM