This is an archive of the discontinued LLVM Phabricator instance.

Differential D69098

Remove -DLLVM_USE_LINKER from Windows self host bots
ClosedPublic

Authored by russell.gallop on Oct 17 2019, 4:07 AM.

Details

Reviewers
rnk
gkistanova
Commits
rZORG061123f05ff0: Remove -DLLVM_USE_LINKER from Windows self host bots.
rL375212: Remove -DLLVM_USE_LINKER from Windows self host bots.
Summary

As discussed in https://reviews.llvm.org/D69030, removing LLVM_USE_LINKER from bots which use that AND setting CMAKE_LINKER.

Diff Detail

Event Timeline

russell.gallop created this revision.Oct 17 2019, 4:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2019, 4:07 AM
russell.gallop added a reviewer: gkistanova.Oct 17 2019, 6:25 AM
rnk accepted this revision.Oct 17 2019, 10:14 AM

lgtm

This revision is now accepted and ready to land.Oct 17 2019, 10:14 AM
russell.gallop closed this revision.Dec 4 2019, 7:15 AM

Committed in 061123f05ff0813c36287d2105cb5344d494592b. Closing.

Revision Contents

PathSize
zorg/
buildbot/
builders/
annotated/
6 lines
6 lines

Diff 225393

zorg/buildbot/builders/annotated/clang-windows.py

Context not available.
projects = ['llvm', 'clang', 'lld', 'debuginfo-tests'] projects = ['llvm', 'clang', 'lld', 'debuginfo-tests']
stages = 2 stages = 2
stage1_extra_cmake_args = [ extra_cmake_args = [
'-DCMAKE_BUILD_TYPE=Release', '-DCMAKE_BUILD_TYPE=Release',
'-DLLVM_ENABLE_PDB=ON', '-DLLVM_ENABLE_PDB=ON',
'-DLLVM_ENABLE_ASSERTIONS=ON', '-DLLVM_ENABLE_ASSERTIONS=ON',
'-DLLVM_TARGETS_TO_BUILD=all', '-DLLVM_TARGETS_TO_BUILD=all',
] ]
extra_cmake_args = stage1_extra_cmake_args + [
'-DLLVM_USE_LINKER=lld',
]
check_targets = ['check-llvm', 'check-clang', 'check-lld', 'check-debuginfo'] check_targets = ['check-llvm', 'check-clang', 'check-lld', 'check-debuginfo']
# Check both stage 1 and stage 2. # Check both stage 1 and stage 2.
Context not available.
builder.run_steps(projects=projects, builder.run_steps(projects=projects,
stages=stages, stages=stages,
extra_cmake_args=extra_cmake_args, extra_cmake_args=extra_cmake_args,
stage1_extra_cmake_args=stage1_extra_cmake_args,
check_targets=check_targets, check_targets=check_targets,
check_stages=check_stages, check_stages=check_stages,
compiler=compiler, compiler=compiler,
Context not available.

zorg/buildbot/builders/annotated/sanitizer-windows.py

Context not available.
projects = ['llvm', 'clang', 'lld', 'compiler-rt'] projects = ['llvm', 'clang', 'lld', 'compiler-rt']
stages = 1 stages = 1
stage1_extra_cmake_args = [ extra_cmake_args = [
'-DCMAKE_BUILD_TYPE=Release', '-DCMAKE_BUILD_TYPE=Release',
'-DLLVM_ENABLE_PDB=ON', '-DLLVM_ENABLE_PDB=ON',
'-DLLVM_ENABLE_ASSERTIONS=ON', '-DLLVM_ENABLE_ASSERTIONS=ON',
'-DLLVM_TARGETS_TO_BUILD=X86', '-DLLVM_TARGETS_TO_BUILD=X86',
] ]
extra_cmake_args = stage1_extra_cmake_args + [
'-DLLVM_USE_LINKER=lld',
]
check_targets = ['check-asan', 'check-asan-dynamic', 'check-sanitizer', check_targets = ['check-asan', 'check-asan-dynamic', 'check-sanitizer',
'check-ubsan', 'check-fuzzer', 'check-cfi', 'check-ubsan', 'check-fuzzer', 'check-cfi',
'check-profile', 'check-builtins'] 'check-profile', 'check-builtins']
Context not available.
builder.run_steps(stages=stages, builder.run_steps(stages=stages,
projects=projects, projects=projects,
extra_cmake_args=extra_cmake_args, extra_cmake_args=extra_cmake_args,
stage1_extra_cmake_args=stage1_extra_cmake_args,
check_targets=check_targets, check_targets=check_targets,
compiler=compiler, compiler=compiler,
linker=linker, linker=linker,
Context not available.