Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Differential
D6894
Fix assertion in BreakableBlockComment (http://llvm.org/PR21916).
Closed
Public
Actions
Authored by
alexfh
on Jan 9 2015, 8:18 AM.
Edit Revision
Update Diff
Download Raw Diff
Edit Related Revisions...
Edit Parent Revisions
Edit Child Revisions
Edit Related Objects...
Edit Commits
Subscribe
Mute Notifications
Award Token
Flag For Later
Tags
None
Subscribers
cfe-commits
,
klimek
Details
Reviewers
djasper
Commits
rL225628: Fix assertion in BreakableBlockComment (http://llvm.org/PR21916).
rG00691cf3bb81: Fix assertion in BreakableBlockComment (http://llvm.org/PR21916).
rC225628: Fix assertion in BreakableBlockComment (http://llvm.org/PR21916).
Diff Detail
Event Timeline
alexfh
updated this revision to
Diff 17927
.
Jan 9 2015, 8:18 AM
alexfh
retitled this revision from
to
Fix assertion in BreakableBlockComment (http://llvm.org/PR21916).
.
alexfh
updated this object.
alexfh
edited the test plan for this revision.
(Show Details)
alexfh
added a reviewer:
djasper
.
alexfh
added a subscriber:
Unknown Object (MLST)
.
Herald
added a subscriber:
klimek
.
·
View Herald Transcript
Jan 9 2015, 8:18 AM
djasper
accepted this revision.
Jan 12 2015, 1:43 AM
djasper
edited edge metadata.
Comment Actions
Looks good.
lib/Format/BreakableToken.h
215
nit: The remaining lines' ...
217
nit: .. \c WhitespaceManager. Thus, they ...
This revision is now accepted and ready to land.
Jan 12 2015, 1:43 AM
alexfh
closed this revision.
Jan 12 2015, 5:12 AM