This is an archive of the discontinued LLVM Phabricator instance.

Differential D68859

Fixing crash in clang IFS for enum, record, and typedef decls.
ClosedPublic

Authored by plotfi on Oct 10 2019, 11:44 PM.

Details

Reviewers
compnerd
Commits
rGe3388c42f39b: [clang][IFS] Fixing assert in clang interface stubs for enums, records, typedefs
rC374573: [clang][IFS] Fixing assert in clang interface stubs for enums, records, typedefs
rL374573: [clang][IFS] Fixing assert in clang interface stubs for enums, records, typedefs

Diff Detail

Event Timeline

plotfi created this revision.Oct 10 2019, 11:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 10 2019, 11:44 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
compnerd accepted this revision.Oct 11 2019, 7:49 AM
This revision is now accepted and ready to land.Oct 11 2019, 7:49 AM
Closed by commit rGe3388c42f39b: [clang][IFS] Fixing assert in clang interface stubs for enums, records, typedefs (authored by plotfi). · Explain WhyOct 11 2019, 10:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
lib/
Frontend/
4 lines
test/
InterfaceStubs/
10 lines

Diff 224629

clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp

Show First 20 Lines • Show All 171 Lines • ▼ Show 20 Lines case Decl::Kind::ClassTemplateSpecialization:
return true; return true;
case Decl::Kind::ClassTemplate: case Decl::Kind::ClassTemplate:
HandleTemplateSpecializations(*cast<ClassTemplateDecl>(ND), Symbols, RDO); HandleTemplateSpecializations(*cast<ClassTemplateDecl>(ND), Symbols, RDO);
return true; return true;
case Decl::Kind::FunctionTemplate: case Decl::Kind::FunctionTemplate:
HandleTemplateSpecializations(*cast<FunctionTemplateDecl>(ND), Symbols, HandleTemplateSpecializations(*cast<FunctionTemplateDecl>(ND), Symbols,
RDO); RDO);
return true; return true;
case Decl::Kind::Record:
case Decl::Kind::Typedef:
case Decl::Kind::Enum:
case Decl::Kind::EnumConstant:
case Decl::Kind::TemplateTypeParm: case Decl::Kind::TemplateTypeParm:
return true; return true;
case Decl::Kind::Var: case Decl::Kind::Var:
case Decl::Kind::ParmVar: case Decl::Kind::ParmVar:
case Decl::Kind::CXXMethod: case Decl::Kind::CXXMethod:
case Decl::Kind::CXXConstructor: case Decl::Kind::CXXConstructor:
case Decl::Kind::CXXDestructor: case Decl::Kind::CXXDestructor:
case Decl::Kind::Function: case Decl::Kind::Function:
▲ Show 20 Lines • Show All 117 Lines • Show Last 20 Lines

clang/test/InterfaceStubs/noninstancetypes.c

  • This file was added.
// RUN: %clang_cc1 -o - -emit-interface-stubs %s | FileCheck %s
// TODO: Change clang_cc1 to clang when llvm-ifs can accept empty symbol lists.
// CHECK: Symbols:
// CHECK-NEXT: ...
struct a;
enum { b };
typedef int c;