This is an archive of the discontinued LLVM Phabricator instance.

Differential D68823

Fix help message for -ffp-contract
ClosedPublic

Authored by yaxunl on Oct 10 2019, 12:06 PM.

Details

Reviewers
tra
Commits
rGc10a64718ed2: Fix help message for -ffp-contract
rL374467: Fix help message for -ffp-contract
rC374467: Fix help message for -ffp-contract

Diff Detail

Event Timeline

yaxunl created this revision.Oct 10 2019, 12:06 PM
tra added inline comments.Oct 10 2019, 1:36 PM
include/clang/Driver/Options.td
1148

Could you point me where we set it? I'm having trouble finding the code that controls it for CUDA.

yaxunl marked an inline comment as done.Oct 10 2019, 2:53 PM
yaxunl added inline comments.
include/clang/Driver/Options.td
1148

https://github.com/llvm-mirror/clang/blob/dea3d1b9fed4a2c2ede2976abc2baba61bd85ac2/lib/Frontend/CompilerInvocation.cpp#L2295

tra accepted this revision.Oct 10 2019, 3:04 PM
tra added inline comments.
include/clang/Driver/Options.td
1148

Thank you. LGTM.

This revision is now accepted and ready to land.Oct 10 2019, 3:04 PM
Closed by commit rGc10a64718ed2: Fix help message for -ffp-contract (authored by yaxunl). · Explain WhyOct 10 2019, 3:49 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 10 2019, 3:49 PM

Revision Contents

PathSize
include/
clang/
Driver/
3 lines

Diff 224436

include/clang/Driver/Options.td

Show First 20 Lines • Show All 1,138 Lines • ▼ Show 20 Lines
def fno_honor_infinities : Flag<["-"], "fno-honor-infinities">, Group<f_Group>; def fno_honor_infinities : Flag<["-"], "fno-honor-infinities">, Group<f_Group>;
// This option was originally misspelt "infinites" [sic]. // This option was originally misspelt "infinites" [sic].
def : Flag<["-"], "fhonor-infinites">, Alias<fhonor_infinities>; def : Flag<["-"], "fhonor-infinites">, Alias<fhonor_infinities>;
def : Flag<["-"], "fno-honor-infinites">, Alias<fno_honor_infinities>; def : Flag<["-"], "fno-honor-infinites">, Alias<fno_honor_infinities>;
def ftrapping_math : Flag<["-"], "ftrapping-math">, Group<f_Group>, Flags<[CC1Option]>; def ftrapping_math : Flag<["-"], "ftrapping-math">, Group<f_Group>, Flags<[CC1Option]>;
def fno_trapping_math : Flag<["-"], "fno-trapping-math">, Group<f_Group>, Flags<[CC1Option]>; def fno_trapping_math : Flag<["-"], "fno-trapping-math">, Group<f_Group>, Flags<[CC1Option]>;
def ffp_contract : Joined<["-"], "ffp-contract=">, Group<f_Group>, def ffp_contract : Joined<["-"], "ffp-contract=">, Group<f_Group>,
Flags<[CC1Option]>, HelpText<"Form fused FP ops (e.g. FMAs): fast (everywhere)" Flags<[CC1Option]>, HelpText<"Form fused FP ops (e.g. FMAs): fast (everywhere)"
" | on (according to FP_CONTRACT pragma, default) | off (never fuse)">, Values<"fast,on,off">; " | on (according to FP_CONTRACT pragma) | off (never fuse). Default"
" is 'fast' for CUDA/HIP and 'on' otherwise.">, Values<"fast,on,off">;
traUnsubmitted
Not Done
ReplyInline Actions

Could you point me where we set it? I'm having trouble finding the code that controls it for CUDA.

tra: Could you point me where we set it? I'm having trouble finding the code that controls it for…
yaxunlAuthorUnsubmitted
Done
ReplyInline Actions

https://github.com/llvm-mirror/clang/blob/dea3d1b9fed4a2c2ede2976abc2baba61bd85ac2/lib/Frontend/CompilerInvocation.cpp#L2295

yaxunl: https://github.com/llvm-mirror/clang/blob/dea3d1b9fed4a2c2ede2976abc2baba61bd85ac2/lib/Frontend…
traUnsubmitted
Not Done
ReplyInline Actions

Thank you. LGTM.

tra: Thank you. LGTM.
def fstrict_float_cast_overflow : Flag<["-"], def fstrict_float_cast_overflow : Flag<["-"],
"fstrict-float-cast-overflow">, Group<f_Group>, Flags<[CC1Option]>, "fstrict-float-cast-overflow">, Group<f_Group>, Flags<[CC1Option]>,
HelpText<"Assume that overflowing float-to-int casts are undefined (default)">; HelpText<"Assume that overflowing float-to-int casts are undefined (default)">;
def fno_strict_float_cast_overflow : Flag<["-"], def fno_strict_float_cast_overflow : Flag<["-"],
"fno-strict-float-cast-overflow">, Group<f_Group>, Flags<[CC1Option]>, "fno-strict-float-cast-overflow">, Group<f_Group>, Flags<[CC1Option]>,
HelpText<"Relax language rules and try to match the behavior of the target's native float-to-int conversion instructions">; HelpText<"Relax language rules and try to match the behavior of the target's native float-to-int conversion instructions">;
▲ Show 20 Lines • Show All 2,127 Lines • Show Last 20 Lines