Page MenuHomePhabricator

Use error instead of fatal to report usage errors
ClosedPublic

Authored by ruiu on Oct 10 2019, 2:14 AM.

Diff Detail

Event Timeline

ruiu created this revision.Oct 10 2019, 2:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 10 2019, 2:14 AM
mstorsjo accepted this revision.Oct 10 2019, 2:36 AM

LGTM

lld/test/MinGW/driver.test
229

There's a separate test file, lib.test, with tests that overlaps this one (-l failures), but I guess it doesn't hurt to have this option tested in both.

This revision is now accepted and ready to land.Oct 10 2019, 2:36 AM
ruiu marked an inline comment as done.Oct 10 2019, 2:43 AM
ruiu added inline comments.
lld/test/MinGW/driver.test
229

Thank you for pointing that out. I didn't notice that. I'll remove this test from here because it seems just redundant.

This revision was automatically updated to reflect the committed changes.