Page MenuHomePhabricator

[clang] prevent crash for nonnull attribut in constant context (Bug 43601)
ClosedPublic

Authored by Tyker on Wed, Oct 9, 10:53 AM.

Diff Detail

Event Timeline

Tyker created this revision.Wed, Oct 9, 10:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Oct 9, 10:53 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
rnk accepted this revision.Wed, Oct 9, 1:06 PM

lgtm, thanks.

clang/lib/AST/ExprConstant.cpp
5444–5445

As an unrelated, optional suggestion, given how common I-Args.begin() is, it seems like it would be simpler to do the usual index iteration pattern here.

This revision is now accepted and ready to land.Wed, Oct 9, 1:06 PM
Tyker updated this revision to Diff 224169.Wed, Oct 9, 2:37 PM
This revision was automatically updated to reflect the committed changes.