This is an archive of the discontinued LLVM Phabricator instance.

Replace static const StringRef with StringRef (NFC)
ClosedPublic

Authored by aprantl on Oct 7 2019, 2:43 PM.

Details

Summary

I just don't think that we are saving anything by making these StringRefs global variables. The strings they reference are constants anyway.

Diff Detail

Event Timeline

aprantl updated this revision to Diff 223664.Oct 7 2019, 2:43 PM
aprantl created this revision.
JDevlieghere accepted this revision.Oct 7 2019, 2:58 PM

LGTM with the g_ prefixes removed.

lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
4199

Looks like this is the same string as above. I believe it's in scope, so we should be able to just reuse it?

This revision is now accepted and ready to land.Oct 7 2019, 2:58 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2019, 9:34 AM