This is an archive of the discontinued LLVM Phabricator instance.

Differential D68379

FunctionDecl::isThisDeclarationADefinition is useless in ProcessDeclAttribute
AbandonedPublic

Authored by gchatelet on Oct 3 2019, 2:09 AM.

Details

Reviewers
None
Summary

This is for illustration purposes and not to be submitted

Diff Detail

Event Timeline

gchatelet created this revision.Oct 3 2019, 2:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 3 2019, 2:09 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B38937: Diff 222979.Oct 3 2019, 2:13 AM
gchatelet mentioned this in D68028: [clang] Add no_builtin attribute.Oct 3 2019, 2:29 AM
gchatelet abandoned this revision.Oct 11 2019, 1:33 AM

Revision Contents

PathSize
clang/
lib/
Sema/
36 lines

Diff 222979

clang/lib/Sema/SemaDeclAttr.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,792 Lines • ▼ Show 20 Linesstatic void handleWeakRefAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
D->addAttr(::new (S.Context) WeakRefAttr(S.Context, AL)); D->addAttr(::new (S.Context) WeakRefAttr(S.Context, AL));
} }
static void handleIFuncAttr(Sema &S, Decl *D, const ParsedAttr &AL) { static void handleIFuncAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
StringRef Str; StringRef Str;
if (!S.checkStringLiteralArgumentAttr(AL, 0, Str)) if (!S.checkStringLiteralArgumentAttr(AL, 0, Str))
return; return;
// Aliases should be on declarations, not definitions. // // Aliases should be on declarations, not definitions.
const auto *FD = cast<FunctionDecl>(D); // const auto *FD = cast<FunctionDecl>(D);
if (FD->isThisDeclarationADefinition()) { // if (FD->isThisDeclarationADefinition()) {
S.Diag(AL.getLoc(), diag::err_alias_is_definition) << FD << 1; // S.Diag(AL.getLoc(), diag::err_alias_is_definition) << FD << 1;
return; // return;
} // }
D->addAttr(::new (S.Context) IFuncAttr(S.Context, AL, Str)); D->addAttr(::new (S.Context) IFuncAttr(S.Context, AL, Str));
} }
static void handleAliasAttr(Sema &S, Decl *D, const ParsedAttr &AL) { static void handleAliasAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
StringRef Str; StringRef Str;
if (!S.checkStringLiteralArgumentAttr(AL, 0, Str)) if (!S.checkStringLiteralArgumentAttr(AL, 0, Str))
return; return;
if (S.Context.getTargetInfo().getTriple().isOSDarwin()) { if (S.Context.getTargetInfo().getTriple().isOSDarwin()) {
S.Diag(AL.getLoc(), diag::err_alias_not_supported_on_darwin); S.Diag(AL.getLoc(), diag::err_alias_not_supported_on_darwin);
return; return;
} }
if (S.Context.getTargetInfo().getTriple().isNVPTX()) { if (S.Context.getTargetInfo().getTriple().isNVPTX()) {
S.Diag(AL.getLoc(), diag::err_alias_not_supported_on_nvptx); S.Diag(AL.getLoc(), diag::err_alias_not_supported_on_nvptx);
} }
// Aliases should be on declarations, not definitions. // Aliases should be on declarations, not definitions.
if (const auto *FD = dyn_cast<FunctionDecl>(D)) { if (const auto *FD = dyn_cast<FunctionDecl>(D)) {
if (FD->isThisDeclarationADefinition()) { // if (FD->isThisDeclarationADefinition()) {
S.Diag(AL.getLoc(), diag::err_alias_is_definition) << FD << 0; // S.Diag(AL.getLoc(), diag::err_alias_is_definition) << FD << 0;
return; // return;
} // }
} else { } else {
const auto *VD = cast<VarDecl>(D); const auto *VD = cast<VarDecl>(D);
if (VD->isThisDeclarationADefinition() && VD->isExternallyVisible()) { if (VD->isThisDeclarationADefinition() && VD->isExternallyVisible()) {
S.Diag(AL.getLoc(), diag::err_alias_is_definition) << VD << 0; S.Diag(AL.getLoc(), diag::err_alias_is_definition) << VD << 0;
return; return;
} }
} }
▲ Show 20 Lines • Show All 3,785 Lines • ▼ Show 20 Lines
static void handleWebAssemblyImportModuleAttr(Sema &S, Decl *D, const ParsedAttr &AL) { static void handleWebAssemblyImportModuleAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
if (!isFunctionOrMethod(D)) { if (!isFunctionOrMethod(D)) {
S.Diag(D->getLocation(), diag::warn_attribute_wrong_decl_type) S.Diag(D->getLocation(), diag::warn_attribute_wrong_decl_type)
<< "'import_module'" << ExpectedFunction; << "'import_module'" << ExpectedFunction;
return; return;
} }
auto *FD = cast<FunctionDecl>(D); auto *FD = cast<FunctionDecl>(D);
if (FD->isThisDeclarationADefinition()) { // if (FD->isThisDeclarationADefinition()) {
S.Diag(D->getLocation(), diag::err_alias_is_definition) << FD << 0; // S.Diag(D->getLocation(), diag::err_alias_is_definition) << FD << 0;
return; // return;
} // }
StringRef Str; StringRef Str;
SourceLocation ArgLoc; SourceLocation ArgLoc;
if (!S.checkStringLiteralArgumentAttr(AL, 0, Str, &ArgLoc)) if (!S.checkStringLiteralArgumentAttr(AL, 0, Str, &ArgLoc))
return; return;
FD->addAttr(::new (S.Context) FD->addAttr(::new (S.Context)
WebAssemblyImportModuleAttr(S.Context, AL, Str)); WebAssemblyImportModuleAttr(S.Context, AL, Str));
} }
static void handleWebAssemblyImportNameAttr(Sema &S, Decl *D, const ParsedAttr &AL) { static void handleWebAssemblyImportNameAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
if (!isFunctionOrMethod(D)) { if (!isFunctionOrMethod(D)) {
S.Diag(D->getLocation(), diag::warn_attribute_wrong_decl_type) S.Diag(D->getLocation(), diag::warn_attribute_wrong_decl_type)
<< "'import_name'" << ExpectedFunction; << "'import_name'" << ExpectedFunction;
return; return;
} }
auto *FD = cast<FunctionDecl>(D); auto *FD = cast<FunctionDecl>(D);
if (FD->isThisDeclarationADefinition()) { // if (FD->isThisDeclarationADefinition()) {
S.Diag(D->getLocation(), diag::err_alias_is_definition) << FD << 0; // S.Diag(D->getLocation(), diag::err_alias_is_definition) << FD << 0;
return; // return;
} // }
StringRef Str; StringRef Str;
SourceLocation ArgLoc; SourceLocation ArgLoc;
if (!S.checkStringLiteralArgumentAttr(AL, 0, Str, &ArgLoc)) if (!S.checkStringLiteralArgumentAttr(AL, 0, Str, &ArgLoc))
return; return;
FD->addAttr(::new (S.Context) WebAssemblyImportNameAttr(S.Context, AL, Str)); FD->addAttr(::new (S.Context) WebAssemblyImportNameAttr(S.Context, AL, Str));
} }
▲ Show 20 Lines • Show All 2,816 Lines • Show Last 20 Lines