This is an archive of the discontinued LLVM Phabricator instance.

Differential D6802

[llgo] irgen: return a types.Package to the compiler client
ClosedPublic

Authored by pcc on Dec 29 2014, 3:22 PM.

Details

Reviewers
axw
Commits
rG76c1d4e4ddbb: irgen: return a types.Package to the compiler client
rL225028: irgen: return a types.Package to the compiler client

Diff Detail

Event Timeline

pcc updated this revision to Diff 17687.Dec 29 2014, 3:22 PM
pcc retitled this revision from to [llgo] irgen: return a types.Package to the compiler client.
pcc updated this object.
pcc edited the test plan for this revision. (Show Details)
pcc added a reviewer: axw.
pcc added a subscriber: Unknown Object (MLST).
axw accepted this revision.Dec 29 2014, 4:34 PM
axw edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 29 2014, 4:34 PM
Closed by commit rL225028: irgen: return a types.Package to the compiler client (authored by pcc). · Explain WhyDec 30 2014, 4:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
irgen/
3 lines

Diff 17687

irgen/compiler.go

Show All 32 Linesimport (
"llvm.org/llgo/third_party/go.tools/go/ssa" "llvm.org/llgo/third_party/go.tools/go/ssa"
"llvm.org/llgo/third_party/go.tools/go/types" "llvm.org/llgo/third_party/go.tools/go/types"
) )
type Module struct { type Module struct {
llvm.Module llvm.Module
Path string Path string
ExportData []byte ExportData []byte
Package *types.Package
disposed bool disposed bool
} }
func (m *Module) Dispose() { func (m *Module) Dispose() {
if m.disposed { if m.disposed {
return return
} }
m.Module.Dispose() m.Module.Dispose()
▲ Show 20 Lines • Show All 140 Lines • ▼ Show 20 Lines if err != nil {
return nil, err return nil, err
} }
program := ssa.Create(iprog, ssa.BareInits) program := ssa.Create(iprog, ssa.BareInits)
mainPkginfo := iprog.InitialPackages()[0] mainPkginfo := iprog.InitialPackages()[0]
mainPkg := program.CreatePackage(mainPkginfo) mainPkg := program.CreatePackage(mainPkginfo)
// Create a Module, which contains the LLVM module. // Create a Module, which contains the LLVM module.
modulename := importpath modulename := importpath
compiler.module = &Module{Module: llvm.NewModule(modulename), Path: modulename} compiler.module = &Module{Module: llvm.NewModule(modulename), Path: modulename, Package: mainPkg.Object}
compiler.module.SetTarget(compiler.TargetTriple) compiler.module.SetTarget(compiler.TargetTriple)
compiler.module.SetDataLayout(compiler.dataLayout) compiler.module.SetDataLayout(compiler.dataLayout)
// Create a new translation unit. // Create a new translation unit.
unit := newUnit(compiler, mainPkg) unit := newUnit(compiler, mainPkg)
// Create the runtime interface. // Create the runtime interface.
compiler.runtime, err = newRuntimeInterface(compiler.module.Module, compiler.llvmtypes) compiler.runtime, err = newRuntimeInterface(compiler.module.Module, compiler.llvmtypes)
▲ Show 20 Lines • Show All 147 Lines • Show Last 20 Lines