Section name is not marked as microMIPS, thus for function symbols relocations should use symbol - not section name.
Details
Details
Diff Detail
Diff Detail
Event Timeline
test/MC/Mips/micromips-func-addr.s | ||
---|---|---|
12 | You can reorder instructions and rename foo to L1 so that it is more obvious that two symbols in the test are function and label. For example (I also marked .4byte directives with .data): .set micromips .type bar,@function bar: L1: nop .data .4byte bar .4byte L1 |
Comment Actions
LGTM, with a change.
lib/Target/Mips/MCTargetDesc/MipsELFObjectWriter.cpp | ||
---|---|---|
14 | Place MCELF.h before MCELFObjectWriter.h because it precedes in alphabetical order. |
Place MCELF.h before MCELFObjectWriter.h because it precedes in alphabetical order.