This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Add completion support for log enable/disable/list
ClosedPublic

Authored by teemperor on Sep 23 2019, 3:47 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

teemperor created this revision.Sep 23 2019, 3:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2019, 3:47 AM
JDevlieghere added inline comments.
lldb/source/Utility/Log.cpp
49 ↗(On Diff #221280)

Is this used outside of CommandObjectLog? Otherwise this should probably go there.

This revision is now accepted and ready to land.Sep 23 2019, 9:26 AM
teemperor marked an inline comment as done.Sep 24 2019, 12:09 AM
teemperor added inline comments.
lldb/source/Utility/Log.cpp
49 ↗(On Diff #221280)

Yeah I think both the channel and category functions are only used once by CommandObjectLog. Will clean that up in a separate NFC commit.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 24 2019, 12:16 AM