Page MenuHomePhabricator

[CodeGenPrepare] Mend "avoid crashing from replacing a phi twice" fix.
ClosedPublic

Authored by JesperAntonsson on Sep 20 2019, 8:36 AM.

Details

Summary

An erroneously negated if-statement by an earlier (March 2019) bugfix left phi replacement/simplification under optimizeMemoryInst() in CodeGenPrepare largely inactivated. The error was found when csmith found that the same assert as in the original bug report could still be triggered in a different way. This patch fixes the bugfix. The original bug was:
https://bugs.llvm.org/show_bug.cgi?id=41052
... and the previous fix was D59358.

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptSep 20 2019, 8:36 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
skatkov accepted this revision.Sep 25 2019, 1:29 AM
This revision is now accepted and ready to land.Sep 25 2019, 1:29 AM
This revision was automatically updated to reflect the committed changes.