Sort Java imports without newline

[yannic]

Right now, this change only adds a test that shows the broken behavior.

SamMaier@ you're the author of https://reviews.llvm.org/D52800 which implemented Java import sorting. Is there a reason to not sort imports when there's more than one in a line?

[SamMaier]

In D66964#1651496, @yannic wrote:

Right now, this change only adds a test that shows the broken behavior.

SamMaier@ you're the author of https://reviews.llvm.org/D52800 which implemented Java import sorting. Is there a reason to not sort imports when there's more than one in a line?

No reason - it never crossed my mind as a use case.

[thakis]

Making the tests in this patch pass sounds good to me too :)

clang/unittests/Format/SortImportsTestJava.cpp

       sortIncludes(FmtStyle, Code, GetCodeRange(Code), "input.java").empty());
 }
 
+TEST_F(SortImportsTestJava, NoNewlineBetweenImports) {
+  EXPECT_EQ("import org.a;\n"
+            "import org.b;",
+            sort("import org.a;import org.b;"));
+  EXPECT_EQ("import org.a;\n"
+            "import org.b;",
+            sort("import org.b;import org.a;"));
+  EXPECT_EQ("import org.a;\n"
+            "import org.b;\n"
+            "import org.c",
+            sort("import org.b;import org.a;\n"
+                 "import org.c;"));
+  EXPECT_EQ("import org.a;\n"
+            "import org.b;\n"
+            "import org.c",
+            sort("import org.c;\n"
+                 "import org.b;import org.a;"));
+}
+
 } // end namespace
 } // end namespace format
 } // end namespace clang