Page MenuHomePhabricator

Sort Java imports without newline
Needs ReviewPublic

Authored by yannic on Thu, Aug 29, 10:48 AM.

Details

Diff Detail

Event Timeline

yannic created this revision.Thu, Aug 29, 10:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Aug 29, 10:48 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Right now, this change only adds a test that shows the broken behavior.

SamMaier@ you're the author of https://reviews.llvm.org/D52800 which implemented Java import sorting. Is there a reason to not sort imports when there's more than one in a line?

Right now, this change only adds a test that shows the broken behavior.

SamMaier@ you're the author of https://reviews.llvm.org/D52800 which implemented Java import sorting. Is there a reason to not sort imports when there's more than one in a line?

No reason - it never crossed my mind as a use case.

Making the tests in this patch pass sounds good to me too :)