Page MenuHomePhabricator

[Fuchsia] Create the VMO during initialization, not during exit
ClosedPublic

Authored by phosek on Aug 15 2019, 4:48 PM.

Details

Summary

We want to avoid doing expensive work during atexit since the process
might be terminated before we can publish the VMO and write out the
symbolizer markup, so move the VMO creation to the initialization
phase and only write data during the atexit phase.

Diff Detail

Event Timeline

phosek created this revision.Aug 15 2019, 4:48 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 15 2019, 4:48 PM
Herald added subscribers: llvm-commits, Restricted Project. · View Herald Transcript
mcgrathr accepted this revision.Aug 15 2019, 4:52 PM

lgtm

compiler-rt/lib/profile/InstrProfilingPlatformFuchsia.c
144

typo: "already"

This revision is now accepted and ready to land.Aug 15 2019, 4:52 PM
This revision was automatically updated to reflect the committed changes.