change asan info msg to use debugger output stream instead of adding to module warning collection

[jasonmolenda]

Summary

When lldb loads a binary that was built -fsanitize=address, it prints an info message via the Module's warning printer; it looks like

warning: (x86_64h) /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/lib/darwin/libclang_rt.asan_osx_dynamic.dylib AddressSanitizer debugger support is active. Memory error breakpoint has been installed and you can now use the 'memory history' command.

Instead, I think we should grab the debugger's output stream and print the message there without the warning/arch/module name. Like

AddressSanitizer debugger support is active. Memory error breakpoint has been installed and you can now use the 'memory history' command.

[kubamracek]

Perfect, LGTM, thanks!

[jasonmolenda]

Landed in r223826.

source/Plugins/InstrumentationRuntime/AddressSanitizer/AddressSanitizerRuntime.cpp

 
 #include "AddressSanitizerRuntime.h"
 
+#include "lldb/Breakpoint/StoppointCallbackContext.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleList.h"
 #include "lldb/Core/PluginInterface.h"
 #include "lldb/Core/PluginManager.h"
-#include "lldb/Core/ModuleList.h"
+#include "lldb/Core/Stream.h"
+#include "lldb/Core/StreamFile.h"
+#include "lldb/Core/ValueObject.h"
+#include "lldb/Interpreter/CommandReturnObject.h"
+#include "lldb/Symbol/Symbol.h"
 #include "lldb/Symbol/SymbolContext.h"
-#include "lldb/Core/Module.h"
+#include "lldb/Target/InstrumentationRuntimeStopInfo.h"
+#include "lldb/Target/StopInfo.h"
 #include "lldb/Target/Target.h"
 #include "lldb/Target/Thread.h"
-#include "lldb/Target/StopInfo.h"
-#include "lldb/Symbol/Symbol.h"
-#include "lldb/Breakpoint/StoppointCallbackContext.h"
-#include "lldb/Core/ValueObject.h"
-#include "lldb/Target/InstrumentationRuntimeStopInfo.h"
-#include "lldb/Core/Debugger.h"
-#include "lldb/Core/Stream.h"
-#include "lldb/Core/StreamFile.h"
 
 using namespace lldb;
 using namespace lldb_private;

     ThreadSP thread = context->exe_ctx_ref.GetThreadSP();
     thread->SetStopInfo(InstrumentationRuntimeStopInfo::CreateStopReasonWithInstrumentationData(*thread, description.c_str(), report));
 
-    instance->m_runtime_module->ReportWarning("AddressSanitizer report breakpoint hit. Use 'thread info -s' to get extended information about the report.\n");
-    
+    if (instance->m_process)
+    {
+        StreamFileSP stream_sp (instance->m_process->GetTarget().GetDebugger().GetOutputFile());
+        if (stream_sp)
+        {
+            stream_sp->Printf ("AddressSanitizer report breakpoint hit. Use 'thread info -s' to get extended information about the report.\n");
+        }
+    }
     // Return true to stop the target, false to just let the target run.
     return true;
 }

     breakpoint->SetBreakpointKind ("address-sanitizer-report");
     m_breakpoint_id = breakpoint->GetID();
     
-    m_runtime_module->ReportWarning("AddressSanitizer debugger support is active. Memory error breakpoint has been installed and you can now use the 'memory history' command.\n");
-    
+    if (m_process)
+    {
+        StreamFileSP stream_sp (m_process->GetTarget().GetDebugger().GetOutputFile());
+        if (stream_sp)
+        {
+                stream_sp->Printf ("AddressSanitizer debugger support is active. Memory error breakpoint has been installed and you can now use the 'memory history' command.\n");
+        }
+    }
+
     m_is_active = true;
 }