This is an archive of the discontinued LLVM Phabricator instance.

Remove use of GCC-style intrinsics as they are non-portable.
ClosedPublic

Authored by zturner on Dec 8 2014, 11:40 AM.

Download Raw Diff

Details

Reviewers

Commits

rG818a3676aa34: Remove use of GCC-style intrinsics, as they are non-portable.
rLLDB223687: Remove use of GCC-style intrinsics, as they are non-portable.
rL223687: Remove use of GCC-style intrinsics, as they are non-portable.

Diff Detail

Repository: rL LLVM

Event Timeline

zturner updated this revision to Diff 17046.Dec 8 2014, 11:40 AM

zturner retitled this revision from to Remove use of GCC-style intrinsics as they are non-portable..

zturner updated this object.

zturner edited the test plan for this revision. (Show Details)

zturner added a reviewer: jasonmolenda.

zturner added a subscriber: Unknown Object (MLST).

Thanks Zachary, I should have known those would be a problem. Please commit.

This revision is now accepted and ready to land.Dec 8 2014, 12:00 PM

Closed by commit rL223687 (authored by @zturner).

Revision Contents

Path

Size

lldb/

trunk/

source/

Symbol/

CompactUnwindInfo.cpp

5 lines

Diff 17047

lldb/trunk/source/Symbol/CompactUnwindInfo.cpp

	Show All 15 Lines
	#include "lldb/Core/Section.h"			#include "lldb/Core/Section.h"
	#include "lldb/Core/ArchSpec.h"			#include "lldb/Core/ArchSpec.h"
	#include "lldb/Core/Module.h"			#include "lldb/Core/Module.h"
	#include "lldb/Core/Section.h"			#include "lldb/Core/Section.h"
	#include "lldb/Symbol/CompactUnwindInfo.h"			#include "lldb/Symbol/CompactUnwindInfo.h"
	#include "lldb/Symbol/ObjectFile.h"			#include "lldb/Symbol/ObjectFile.h"
	#include "lldb/Symbol/UnwindPlan.h"			#include "lldb/Symbol/UnwindPlan.h"

				#include "llvm/Support/MathExtras.h"

	using namespace lldb;			using namespace lldb;
	using namespace lldb_private;			using namespace lldb_private;


	namespace lldb_private {			namespace lldb_private {

	// Constants from <mach-o/compact_unwind_encoding.h>			// Constants from <mach-o/compact_unwind_encoding.h>

	▲ Show 20 Lines • Show All 72 Lines • ▼ Show 20 Lines
	#define UNWIND_INFO_COMPRESSED_ENTRY_FUNC_OFFSET(entry) (entry & 0x00FFFFFF)			#define UNWIND_INFO_COMPRESSED_ENTRY_FUNC_OFFSET(entry) (entry & 0x00FFFFFF)
	#endif			#endif

	#ifndef UNWIND_INFO_COMPRESSED_ENTRY_ENCODING_INDEX			#ifndef UNWIND_INFO_COMPRESSED_ENTRY_ENCODING_INDEX
	#define UNWIND_INFO_COMPRESSED_ENTRY_ENCODING_INDEX(entry) ((entry >> 24) & 0xFF)			#define UNWIND_INFO_COMPRESSED_ENTRY_ENCODING_INDEX(entry) ((entry >> 24) & 0xFF)
	#endif			#endif

	#define EXTRACT_BITS(value, mask) \			#define EXTRACT_BITS(value, mask) \
	( (value >> __builtin_ctz(mask)) & (((1 << __builtin_popcount(mask)))-1) )			( (value >> llvm::countTrailingZeros(static_cast<uint32_t>(mask), llvm::ZB_Width)) & \
				(((1 << llvm::CountPopulation_32(static_cast<uint32_t>(mask))))-1) )



	//----------------------			//----------------------
	// constructor			// constructor
	//----------------------			//----------------------


	▲ Show 20 Lines • Show All 855 Lines • Show Last 20 Lines