Page MenuHomePhabricator

Fix TestThreadSpecificBreakpoint on Windows
ClosedPublic

Authored by amccarth on Jul 31 2019, 3:46 PM.

Details

Summary

This test was frequently hanging on Windows, causing a timeout after 10 minutes. The short delay (100 microsecond) in the sample program could cause a deadlock in the Windows thread pool, as I've explained in the test program's comments.

Now that it doesn't hang, it passes reliably, so I've removed the Windows-specific XFAIL.

I've tried to clarify the comments in TestThreadSpecificGBreakpoint.py by eliminating some redundancy and typos, and I simplified away a couple unnecessary assignments.

Diff Detail

Repository
rL LLVM

Event Timeline

amccarth created this revision.Jul 31 2019, 3:46 PM
stella.stamenova accepted this revision.Jul 31 2019, 3:55 PM

LGTM. Please keep an eye on the bot after you commit though

This revision is now accepted and ready to land.Jul 31 2019, 3:55 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 1 2019, 7:50 AM