This is an archive of the discontinued LLVM Phabricator instance.

[clang-doc] Fix failing tests on Windows
ClosedPublic

Authored by DiegoAstiazaran on Jul 29 2019, 2:18 PM.

Reviewers

Commits

Summary

Tests on Windows were failing due to path separator differences.
Links in HTML should use posix-style paths.

This revision is now accepted and ready to land.Jul 29 2019, 2:51 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

clang-tools-extra/

trunk/

clang-doc/

2 lines

	Show First 20 Lines • Show All 246 Lines • ▼ Show 20 Lines

	static std::unique_ptr<HTMLNode> genTypeReference(const Reference &Type,			static std::unique_ptr<HTMLNode> genTypeReference(const Reference &Type,
	StringRef CurrentDirectory) {			StringRef CurrentDirectory) {
	if (Type.Path.empty())			if (Type.Path.empty())
	return llvm::make_unique<TextNode>(Type.Name);			return llvm::make_unique<TextNode>(Type.Name);
	llvm::SmallString<128> Path =			llvm::SmallString<128> Path =
	computeRelativePath(Type.Path, CurrentDirectory);			computeRelativePath(Type.Path, CurrentDirectory);
	llvm::sys::path::append(Path, Type.Name + ".html");			llvm::sys::path::append(Path, Type.Name + ".html");
				// Paths in HTML must be in posix-style
				llvm::sys::path::native(Path, llvm::sys::path::Style::posix);
	return genLink(Type.Name, Path);			return genLink(Type.Name, Path);
	}			}

	static std::vector<std::unique_ptr<HTMLNode>>			static std::vector<std::unique_ptr<HTMLNode>>
	genReferenceList(const llvm::SmallVectorImpl<Reference> &Refs,			genReferenceList(const llvm::SmallVectorImpl<Reference> &Refs,
	const StringRef &CurrentDirectory) {			const StringRef &CurrentDirectory) {
	std::vector<std::unique_ptr<HTMLNode>> Out;			std::vector<std::unique_ptr<HTMLNode>> Out;
	for (const auto &R : Refs) {			for (const auto &R : Refs) {
	▲ Show 20 Lines • Show All 376 Lines • Show Last 20 Lines