This is an archive of the discontinued LLVM Phabricator instance.

Fix a crash in dotest.py when the lldb executable is not built.
ClosedPublic

Authored by sas on Dec 3 2014, 4:47 PM.

Reviewers

domipheus
clayborg

Commits

Summary

If lldb is not built, dotest.py throws an exception because we are using an unset variable.

sas retitled this revision from to Fix a crash in dotest.py when the lldb executable is not built..

sas updated this object.

sas edited the test plan for this revision. (Show Details)

sas added a reviewer: clayborg.

sas added a subscriber: Unknown Object (MLST).

lgtm

This revision is now accepted and ready to land.Dec 3 2014, 5:28 PM

Closed by commit rL223446 (authored by @sas).

Path

Size

lldb/

trunk/

test/

2 lines

Show First 20 Lines • Show All 1,005 Lines • ▼ Show 20 Lines	if not lldbExec:
print "The 'lldb' executable cannot be located. Some of the tests may not be run as a result."		print "The 'lldb' executable cannot be located. Some of the tests may not be run as a result."
else:		else:
os.environ["LLDB_EXEC"] = lldbExec		os.environ["LLDB_EXEC"] = lldbExec
#print "The 'lldb' from PATH env variable", lldbExec		#print "The 'lldb' from PATH env variable", lldbExec

# Assume lldb-mi is in same place as lldb		# Assume lldb-mi is in same place as lldb
# If not found, disable the lldb-mi tests		# If not found, disable the lldb-mi tests
global dont_do_lldbmi_test		global dont_do_lldbmi_test
if is_exe(lldbExec + "-mi"):		if lldbExec and is_exe(lldbExec + "-mi"):
lldbMiExec = lldbExec + "-mi"		lldbMiExec = lldbExec + "-mi"
if not lldbMiExec:		if not lldbMiExec:
dont_do_lldbmi_test = True		dont_do_lldbmi_test = True
if just_do_lldbmi_test:		if just_do_lldbmi_test:
print "The 'lldb-mi' executable cannot be located. The lldb-mi tests can not be run as a result."		print "The 'lldb-mi' executable cannot be located. The lldb-mi tests can not be run as a result."
else:		else:
print "The 'lldb-mi' executable cannot be located. Some of the tests may not be run as a result."		print "The 'lldb-mi' executable cannot be located. Some of the tests may not be run as a result."
else:		else:
▲ Show 20 Lines • Show All 771 Lines • Show Last 20 Lines