This is an archive of the discontinued LLVM Phabricator instance.

Removal Of Duplicate Test Case from shift.ll file.
ClosedPublic

Authored by sonamkumari on Dec 2 2014, 9:04 PM.

Details

Reviewers
suyog
arsenm
Summary

Hi,

The removed duplicate test case matches with the following test case at Line No : 57.

Please help in reviewing it.

Regards,
Sonam.

Diff Detail

Event Timeline

sonamkumari updated this revision to Diff 16850.Dec 2 2014, 9:04 PM
sonamkumari retitled this revision from to Removal Of Duplicate Test Case from shift.ll file..
sonamkumari updated this object.
sonamkumari edited the test plan for this revision. (Show Details)
sonamkumari added a reviewer: suyog.
sonamkumari updated this object.
sonamkumari added a subscriber: Unknown Object (MLST).
arsenm edited edge metadata.Dec 4 2014, 11:00 AM

This shouldn't be removed, the duplicate test should be fixed. @test5_non_splat_vector at line 57 isn't supposed to be a duplicate.
at line 57 should be using a lshr not a shl

sonamkumari edited edge metadata.

Hi Matt,

Thanks for reviewing the patch. Made the changes as per your comments.
Please help in reviewing it.

Regards,
Sonam.

arsenm accepted this revision.Dec 5 2014, 10:11 AM
arsenm edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 5 2014, 10:11 AM
sonamkumari closed this revision.Dec 8 2014, 1:42 AM

Closed by commit rL223648 (authored by @sonamkumari )