Page MenuHomePhabricator

Silence backend complaints on x86 Android
ClosedPublic

Authored by george.burgess.iv on Jul 15 2019, 5:26 PM.

Details

Summary

r364352 started passing a new target-feature for builds with an Android x86 target. On master, this results in 'warnings' from the backend:

$ echo 'int main() {}' | llvm/clean/build/release/bin/clang++ --target=x86_64-linux-android -c -x c++ - -o /dev/null
'+mcx16' is not a recognized feature for this target (ignoring feature)
'+mcx16' is not a recognized feature for this target (ignoring feature)
'+mcx16' is not a recognized feature for this target (ignoring feature)
$

From context, my best guess is that this was just a little typo. Unsure if this is the right fix (and if it is the right fix, if we want more testing around this). Thoughts appreciated :)

Diff Detail

Repository
rL LLVM

Event Timeline

compnerd accepted this revision.Jul 16 2019, 8:48 AM

That is indeed a typo. I somehow ended up copying the driver flag instead of the feature flag. Thanks for fixing this!

I suppose that we could actually make the unknown features a hard error (use of the frontend is unsupported, users should be using the driver, which should always have the correct value). That seems beyond the scope of the actual fix though, lets get this fixed first :-)

This revision is now accepted and ready to land.Jul 16 2019, 8:48 AM

SGTM. Thanks for the review!

Closed by commit rL366276: Fix a typo in target features (authored by gbiv, committed by ). · Explain WhyJul 16 2019, 3:32 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 16 2019, 3:32 PM