This commit enables the MIPS-III target and adds support for code
generation of SELECT nodes. We have to use pseudo-instructions with
custom inserters for these nodes as MIPS-III CPUs do not have
conditional-move instructions.
Depends on D6212
Paths
| Differential D6464
[mips] Enable code generation for MIPS-III. ClosedPublic Authored by vkalintiris on Dec 1 2014, 9:27 AM.
Details Summary This commit enables the MIPS-III target and adds support for code Depends on D6212
Diff Detail Event Timelinevkalintiris updated this object. vkalintiris added a parent revision: D6212: [mips] Support SELECT nodes for targets that don't have conditional-move instructions.. dsanders edited edge metadata. Comment ActionsLGTM with a style nit and with the DecoderNamespace's removed (if they aren't really needed).
This revision is now accepted and ready to land.Dec 8 2014, 7:29 AM Closed by commit rL224128: [mips] Enable code generation for MIPS-III. (authored by vkalintiris). · Explain WhyDec 12 2014, 7:17 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 16772 lib/Target/Mips/MipsCondMov.td
lib/Target/Mips/MipsISelLowering.cpp
lib/Target/Mips/MipsSubtarget.cpp
test/CodeGen/Mips/llvm-ir/select.ll
|
Style nit:
is preferable if the let only applies to a single def. Similarly below.
One related question is: Is it necessary to set the DecoderNamespace? As far as I know it only affects the disassembler tables and pseudo's aren't included in those tables.