Page MenuHomePhabricator

[ASan] Fix leak tests on 64-bit targets other than x86-64 (take two)
ClosedPublic

Authored by foad on Nov 24 2014, 3:24 PM.

Details

Summary

First, remove lit configuration that sets ASAN_OPTIONS to detect_leaks=1
because this is already the default when leak detection is supported.
This removes a bit of duplication between various lit.cfg files.

Second, add a new feature 'leak-detection' if we're targetting x86_64
(not i386) on Linux.

Third, change a couple of tests that need leak detection to require the
new 'leak-detection' feature.

Diff Detail

Event Timeline

foad updated this revision to Diff 16587.Nov 24 2014, 3:24 PM
foad retitled this revision from to [ASan] Fix leak tests on 64-bit targets other than x86-64 (take two).
foad updated this object.
foad edited the test plan for this revision. (Show Details)
foad added reviewers: kcc, samsonov, earthdok.
foad added a subscriber: Unknown Object (MLST).
samsonov accepted this revision.Nov 24 2014, 3:35 PM
samsonov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 24 2014, 3:35 PM
foad closed this revision.Nov 24 2014, 11:56 PM
foad added a comment.Nov 25 2014, 1:53 AM

For the record, "take one" was D6189.