Page MenuHomePhabricator

[swig] Define attribute(ref) instead of accessing swig internals.
ClosedPublic

Authored by JDevlieghere on Jun 18 2019, 4:40 PM.

Details

Summary

As of SWIG 4.0, __swig_getmethods__ and __swig_setmethods__ are no longer defined. The solution is to stop using these internal swig dictionaries and use %attribute and %attributeref instead. I plan on doing this incrementally, with this differential serving as an example.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Jun 18 2019, 4:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2019, 4:40 PM

Add more classes and keep documentation on properties.

labath accepted this revision.Jun 18 2019, 11:46 PM
labath added a subscriber: labath.

I'm not terribly familiar with this, but it definitely looks like a more idiomatic way to do these things.

This revision is now accepted and ready to land.Jun 18 2019, 11:46 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptTue, Jul 2, 10:25 AM