Page MenuHomePhabricator

[GN] Generation failure caused by trailing space in file name
ClosedPublic

Authored by myhsu on Jun 17 2019, 11:04 AM.

Details

Summary

Hi,

When I executed gn.py gen out/gn I got the following error:

ERROR at //compiler-rt/lib/builtins/BUILD.gn:162:7: Only source, header, and object files belong in the sources of a static_library. //compiler-rt/lib/builtins/emutls.c  is not one of the valid types.
      "emutls.c ",
      ^----------
See //compiler-rt/lib/BUILD.gn:3:5: which caused the file to be included.
    "//compiler-rt/lib/builtins",
    ^---------------------------

It turns out to be that the latest gn doesn't accept ill-format file name. And the emutls.c above has a trailing space.
Remove the trailing space should work.

Diff Detail

Repository
rL LLVM

Event Timeline

myhsu created this revision.Jun 17 2019, 11:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2019, 11:04 AM
phosek accepted this revision.Jun 17 2019, 2:50 PM

LGTM

This revision is now accepted and ready to land.Jun 17 2019, 2:50 PM

Thanks for the review. I don't have commit permission, can you help me to commit?

This revision was automatically updated to reflect the committed changes.