This is an archive of the discontinued LLVM Phabricator instance.

[yaml2obj] - Allow setting the custom Address for .strtab
ClosedPublic

Authored by grimar on Jun 11 2019, 7:08 AM.

Details

Summary

Despite the fact that .strtab is non-allocatable,
there is no reason to disallow setting the custom address
for it.

The patch also adds a test case showing we can set any address
we want for other implicit sections.

Depends on D63136

Diff Detail

Event Timeline

grimar created this revision.Jun 11 2019, 7:08 AM

LGTM, with one nit.

test/tools/yaml2obj/implicit-sections-addr.yaml
5

Please add spaces after each ','.

tools/yaml2obj/yaml2elf.cpp
492

If the section

This revision was not accepted when it landed; it landed in state Needs Review.Jun 14 2019, 4:14 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2019, 4:14 AM