This is an archive of the discontinued LLVM Phabricator instance.

[yaml2elf] - Check we are able to set custom sh_link for .symtab/.dynsym
ClosedPublic

Authored by grimar on Jun 10 2019, 8:16 AM.

Details

Summary

Allow using both custom numeric and string values for Link field of the
dynamic and regular symbol tables.

Diff Detail

Event Timeline

grimar created this revision.Jun 10 2019, 8:16 AM
jhenderson accepted this revision.Jun 10 2019, 9:28 AM

Looks good, aside from a few comment issues.

test/tools/yaml2obj/dynsymtab-shlink.yaml
75

"use a section name..."

test/tools/yaml2obj/symtab-shlink.yaml
72

Ditto

tools/yaml2obj/yaml2elf.cpp
408

If the Link ...

This revision is now accepted and ready to land.Jun 10 2019, 9:28 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2019, 2:58 AM