Page MenuHomePhabricator

[bindings/go][NFC] Format code with go fmt
ClosedPublic

Authored by aykevl on Jun 9 2019, 3:29 AM.

Details

Summary

Run go fmt (version 1.12) over the Go bindings. This cleans up lots of inconsistencies in the code, it does not change the code in a functional way.

Diff Detail

Repository
rL LLVM

Event Timeline

aykevl created this revision.Jun 9 2019, 3:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2019, 3:29 AM
jdoerfert accepted this revision.EditedJun 9 2019, 3:03 PM
jdoerfert added a subscriber: jdoerfert.

LGTM, but you should be careful. People sometimes like to keep the history so formating changes are hard. However, this seems to be only binding code so there is not much logic or history thereof to preserve.

This revision is now accepted and ready to land.Jun 9 2019, 3:03 PM
This revision was automatically updated to reflect the committed changes.

Yes, losing a bit of history is unfortunate. However, it will make it easier in the future to keep these bindings machine-formatted.

I don't know how well you know the Go language, but running go fmt on code is the standard basically everywhere. It's so great to not have to bikeshed about formatting.