Page MenuHomePhabricator

Do not derive no-recurse attribute if function does not have exact definition.
ClosedPublic

Authored by vivekvpandya on Jun 8 2019, 4:15 AM.

Diff Detail

Event Timeline

vivekvpandya created this revision.Jun 8 2019, 4:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2019, 4:15 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
jdoerfert accepted this revision.Jun 8 2019, 8:32 AM

LGTM. Though I hope to remove the FunctionAttr code soonish.

This revision is now accepted and ready to land.Jun 8 2019, 8:32 AM

LGTM. Though I hope to remove the FunctionAttr code soonish.

If this code will be removed do we need to commit this?
if yes then is my testing enough?
I have tested this change with check-all (where my build has all targets, clang project enabled)
I am missing anything on testing?

LGTM. Though I hope to remove the FunctionAttr code soonish.

If this code will be removed do we need to commit this?

We should.

if yes then is my testing enough?

I think so.

I have tested this change with check-all (where my build has all targets, clang project enabled)

Good.

I am missing anything on testing?

No.

This revision was automatically updated to reflect the committed changes.