This is an archive of the discontinued LLVM Phabricator instance.

Add cdb test for inline line tables
ClosedPublic

Authored by rnk on May 31 2019, 4:09 PM.

Details

Summary

This creates an integration test for inlined call line tables, and in
particular, ones that are discontiguous.

The test was reduced from https://crbug.com/965670

Depends on D62701

Diff Detail

Repository
rL LLVM

Event Timeline

rnk created this revision.May 31 2019, 4:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2019, 4:09 PM
Herald added a subscriber: eraman. · View Herald Transcript
thakis accepted this revision.Jun 1 2019, 9:59 AM

lgtm

debuginfo-tests/win_cdb/inline-line-gap.cpp
2 ↗(On Diff #202504)

What are the [] needed for? Isn't DE[B]UGGER equivalent to just DEBUGGER?

This revision is now accepted and ready to land.Jun 1 2019, 9:59 AM
rnk marked an inline comment as done.Jun 3 2019, 11:11 AM
rnk added inline comments.
debuginfo-tests/win_cdb/inline-line-gap.cpp
2 ↗(On Diff #202504)

It's a workaround to prevent the grep from matching the RUN: grep line itself. Longer term, we could lift this pattern up into a Python script that does fancier stuff, like emitting a CHECK line of > ${cmd}, since most debugger commands are really short (r) and could match anywhere unintentionally.

This revision was automatically updated to reflect the committed changes.