Page MenuHomePhabricator

[ThinLTO] Use original alias visibility when importing
ClosedPublic

Authored by tejohnson on May 28 2019, 11:01 AM.

Details

Summary

When we import an alias, we do so by making a clone of the aliasee. Just
as this clone uses the original alias name and linkage, it should also
use the same visibility (not the aliasee's visibility). Otherwise,
linker behavior is affected (e.g. if the aliasee was hidden, but the
alias is not, the resulting imported clone should not be hidden,
otherwise the linker will make the final symbol hidden which is
incorrect).

Diff Detail

Repository
rL LLVM

Event Timeline

tejohnson created this revision.May 28 2019, 11:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2019, 11:01 AM
wmi accepted this revision.May 29 2019, 8:42 AM

LGTM.

This revision is now accepted and ready to land.May 29 2019, 8:42 AM
This revision was automatically updated to reflect the committed changes.