Page MenuHomePhabricator

Make sure GetObjectDescription falls back to the Objective-C runtime.
ClosedPublic

Authored by aprantl on May 16 2019, 10:01 AM.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

aprantl created this revision.May 16 2019, 10:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2019, 10:01 AM
aprantl marked an inline comment as done.May 16 2019, 10:01 AM
aprantl added inline comments.
lldb/source/Core/ValueObject.cpp
1112 ↗(On Diff #199852)

This check was redundant, it is also performed by the ObjC runtime.

My one concern is how this will work in a swift-lldb where we have a swift ValueObject, the print description fails, and we fall back to the ObjC print description. That's a change in behavior, right? I imagine worst case is that the objc print description will fail to produce anything and we'll have the same behavior as we do today.

lldb/packages/Python/lldbsuite/test/lang/objcxx/cxx-bridged-po/TestObjCXXBridgedPO.py
16 ↗(On Diff #199852)

@skipUnlessDarwin

aprantl updated this revision to Diff 199859.May 16 2019, 11:03 AM

Address review feedback.

aprantl updated this revision to Diff 199860.May 16 2019, 11:04 AM
aprantl marked an inline comment as done.
jasonmolenda accepted this revision.May 16 2019, 11:05 AM
This revision is now accepted and ready to land.May 16 2019, 11:05 AM
aprantl updated this revision to Diff 199862.May 16 2019, 11:19 AM

Added test for raw pointer values.

This revision was automatically updated to reflect the committed changes.