MSVC warns that not all control paths return a value when a switch doesn't have a default case handler. Changed explicit value checks to a default check. Also, it caught a case where bitwise AND was being used instead of logical AND. I'm not sure what this fixes, but presumably it is not covered by any kind of test case.
Details
Details
- Reviewers
jasonmolenda
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Nice catch on the UnwindAssembly bug, thanks.. LazyBools only have three possible states (and aren't going to gain extra states in the future) so the code in CommandInterpreter was safe - but silencing warnings is always good to do so we can spot real issues. Thanks.