Page MenuHomePhabricator

Re-enable a test for non-Windows

Authored by probinson on May 9 2019, 12:23 PM.



Required teaching to distinguish Windows the same way other projects do.

Diff Detail

Event Timeline

probinson created this revision.May 9 2019, 12:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 9 2019, 12:23 PM
stella.stamenova requested changes to this revision.May 9 2019, 12:29 PM
stella.stamenova added inline comments.

This should be system-windows. See in llvm. By using system-windows, the test would be consistent with other platforms. Incidentally, I am just about to fix this as well as the test in LLVM that you changed to use windows - it should also use system-windows.


This really should live in in llvm so that it can be used across all projects. And it should be system-windows for consistency with other platforms.

This revision now requires changes to proceed.May 9 2019, 12:29 PM
probinson abandoned this revision.May 9 2019, 12:48 PM

@stella.stamenova fixed this using system-windows instead.