This is an archive of the discontinued LLVM Phabricator instance.

lld-link: Make "duplicate resource" error message a bit more concise
ClosedPublic

Authored by thakis on May 1 2019, 10:18 AM.

Details

Summary

Reduces the error message from:

lld-link: error: failed to parse .res file: duplicate resource: type STRINGTABLE (ID 6)/name ID 3/language 1033, in test1.res and in test2.res

To:

lld-link: error: duplicate resource: type STRINGTABLE (ID 6)/name ID 3/language 1033, in test1.res and in test2.res

Make sure every error message emitted by cvtres contains the name of at least one ".res" file, so that removing the "failed to parse .res file" string doesn't lose information.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

thakis created this revision.May 1 2019, 10:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 1 2019, 10:18 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
This revision is now accepted and ready to land.May 1 2019, 12:44 PM
This revision was automatically updated to reflect the committed changes.