This is an archive of the discontinued LLVM Phabricator instance.

[ScriptInterpreter] Move ownership into debugger (NFC)
ClosedPublic

Authored by JDevlieghere on Apr 26 2019, 1:57 PM.

Details

Summary

This is part two of the change started in r359330. This patch moves the ownership of the script interpreter from the command interpreter into the debugger. I would've preferred to remove the lazy initialization, however the fact that the scripting language is set after the debugger is created makes that tricky. So for now this does exactly the same thing as when it was under the command interpreter. The result is that this patch is fully NFC.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

JDevlieghere created this revision.Apr 26 2019, 1:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2019, 1:57 PM
jingham accepted this revision.Apr 26 2019, 3:05 PM

That looks nicer!

This revision is now accepted and ready to land.Apr 26 2019, 3:05 PM
This revision was automatically updated to reflect the committed changes.