Page MenuHomePhabricator

[lldb] Don't filter variable list when doing a lookup by mangled name in SymbolFileDWARF::FindGlobalVariables
ClosedPublic

Authored by kubamracek on Apr 15 2019, 4:27 PM.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

kubamracek created this revision.Apr 15 2019, 4:27 PM
labath added a subscriber: labath.Apr 15 2019, 11:09 PM

A test case?

Adding a test case.

One picky comment about the test, otherwise this looks good to me. Pavel had his hands in this code most recently, however, so we should wait on his opinion.

packages/Python/lldbsuite/test/lang/cpp/global_variables/TestGlobalVariables.py
32–42

Can you use lldbutil.run_to_source_breakpoint to do this? Like:

lldbutil.run_to_source_breakpoint(self, "//Set break point at this line", self.source)

Updating test to use run_to_source_breakpoint

kubamracek marked an inline comment as done.Apr 16 2019, 11:28 AM

Thanks for adding the test.

I guess I've touched this bit when I was working on the dwarf5 index thingy, but all my memory of this function has already been swapped out (and I'm not sure I ever fully understood all the nuances of how it was supposed to work).

So yeah, I think this is fine but I don't feel very qualified to make that claim.

packages/Python/lldbsuite/test/lang/cpp/global_variables/TestGlobalVariables.py
21

I don't think this bug applies here, as we're inspecting a running process, though we don't have any arm64 bots running ATM to verify that. I'd just remove this XFAIL.

Okay. @jingham, any more comments, or is this okay to land?

kubamracek marked an inline comment as done.Apr 17 2019, 10:52 AM
This revision is now accepted and ready to land.Apr 17 2019, 10:59 AM
This revision was automatically updated to reflect the committed changes.