Page MenuHomePhabricator

[LoopPred] Stop passing around builders [NFC]

Authored by reames on Apr 15 2019, 9:33 AM.



This is a preparatory patch for D60093. This patch itself is NFC, but while preparing this I noticed and committed a small hoisting change in rL358419.

The basic structure of the new scheme is that we pass around the guard ("the using instruction"), and select an optimal insert point by examining operands at each construction point. This seems conceptually a bit cleaner to start with as it isolates the knowledge about insertion safety at the actual insertion point.

Note that the non-hoisting path is not actually used at the moment. That's not exercised until D60093 is rebased on this one.

Diff Detail


Event Timeline

reames created this revision.Apr 15 2019, 9:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2019, 9:33 AM
apilipenko accepted this revision.Apr 15 2019, 10:35 AM
This revision is now accepted and ready to land.Apr 15 2019, 10:35 AM
This revision was automatically updated to reflect the committed changes.