This is an archive of the discontinued LLVM Phabricator instance.

Fix CMake Invalid Escape Sequence
ClosedPublic

Authored by xoviat on Apr 13 2019, 1:52 PM.

Download Raw Diff

Details

Reviewers

Commits

rZORGa61d2cf0d9c6: Fix CMake Invalid Escape Sequence
rZORGca124acd41c0: Fix CMake Invalid Escape Sequence
rGa61d2cf0d9c6: Fix CMake Invalid Escape Sequence
rGca124acd41c0: Fix CMake Invalid Escape Sequence
rG9ce8b7e95f8b: Fix CMake Invalid Escape Sequence
rL360045: Fix CMake Invalid Escape Sequence

Summary

On CMake 3.14, I received the following error: Invalid Escape sequence. This patch resolves the error.

Diff Detail

Repository: rL LLVM

Event Timeline

xoviat created this revision.Apr 13 2019, 1:52 PM

Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2019, 1:52 PM

Herald added subscribers: llvm-commits, mgorny. · View Herald Transcript

xoviat added a reviewer: aganea.Apr 13 2019, 1:53 PM

Thanks for the fix!

This revision is now accepted and ready to land.Apr 15 2019, 5:26 AM

Do you have commit access? Should I commit this for you?

I don't have commit access.

I've commited the patch, and quoted you as the maker. You should maybe consider asking commit rights if you're planning more changes in the future?

Closed by commit rL360045: Fix CMake Invalid Escape Sequence (authored by aganea). · Explain WhyMay 6 2019, 7:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

cmake/

modules/

HandleLLVMOptions.cmake

2 lines

Diff 198273

llvm/trunk/cmake/modules/HandleLLVMOptions.cmake

	# This CMake module is responsible for interpreting the user defined LLVM_			# This CMake module is responsible for interpreting the user defined LLVM_
	# options and executing the appropriate CMake commands to realize the users'			# options and executing the appropriate CMake commands to realize the users'
	# selections.			# selections.

	# This is commonly needed so make sure it's defined before we include anything			# This is commonly needed so make sure it's defined before we include anything
	# else.			# else.
	string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)			string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)

	include(CheckCompilerVersion)			include(CheckCompilerVersion)
	include(HandleLLVMStdlib)			include(HandleLLVMStdlib)
	include(CheckCCompilerFlag)			include(CheckCCompilerFlag)
	include(CheckCXXCompilerFlag)			include(CheckCXXCompilerFlag)
	include(CheckSymbolExists)			include(CheckSymbolExists)

	if(CMAKE_LINKER MATCHES "lld-link\.exe" OR (WIN32 AND LLVM_USE_LINKER STREQUAL "lld") OR LLVM_ENABLE_LLD)			if(CMAKE_LINKER MATCHES "lld-link\\.exe" OR (WIN32 AND LLVM_USE_LINKER STREQUAL "lld") OR LLVM_ENABLE_LLD)
	set(LINKER_IS_LLD_LINK TRUE)			set(LINKER_IS_LLD_LINK TRUE)
	else()			else()
	set(LINKER_IS_LLD_LINK FALSE)			set(LINKER_IS_LLD_LINK FALSE)
	endif()			endif()

	set(LLVM_CXX_STD_default "c++11")			set(LLVM_CXX_STD_default "c++11")
	# Preserve behaviour of legacy cache variables			# Preserve behaviour of legacy cache variables
	if (LLVM_ENABLE_CXX1Y)			if (LLVM_ENABLE_CXX1Y)
	▲ Show 20 Lines • Show All 968 Lines • Show Last 20 Lines