Page MenuHomePhabricator

Improve visited block tracking in isPotentiallyReachable.
Needs ReviewPublic

Authored by nicholas on Apr 5 2019, 9:22 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

The outermost loop check and dominator check cover multiple blocks, but we only entered one of the blocks in Visited. Add all blocks we really checked to avoid visiting them again.

In one sense there's no functionality change, but this does change how the accounting towards the threshold is handled. Skipping a visited block does not count towards the block limit.

Diff Detail

Event Timeline

nicholas created this revision.Apr 5 2019, 9:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2019, 9:22 PM
nicholas updated this revision to Diff 194004.Apr 5 2019, 9:27 PM
nicholas retitled this revision from Improve visited block tracking is isPotentiallyReachable. to Improve visited block tracking in isPotentiallyReachable..
nicholas edited the summary of this revision. (Show Details)Apr 6 2019, 12:50 AM