This is an archive of the discontinued LLVM Phabricator instance.

Differential D60301

[CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata.
AbandonedPublic

Authored by ahatanak on Apr 4 2019, 6:43 PM.

Details

Reviewers
steven_wu
dexonsmith
rjmccall

Diff Detail

Repository
rC Clang

Event Timeline

ahatanak created this revision.Apr 4 2019, 6:43 PM
Herald added a subscriber: jkorous. · View Herald TranscriptApr 4 2019, 6:43 PM
ahatanak abandoned this revision.Apr 4 2019, 6:46 PM

I'll write the summary and send the patch again.

Revision Contents

PathSize
lib/
CodeGen/
12 lines
test/
CodeGenObjC/
3 lines

Diff 193820

lib/CodeGen/CGObjC.cpp

Show First 20 Lines • Show All 2,155 Lines • ▼ Show 20 Lines // in a moment.
llvm::FunctionType::get(CGF.VoidTy, /*variadic*/false); llvm::FunctionType::get(CGF.VoidTy, /*variadic*/false);
marker = llvm::InlineAsm::get(type, assembly, "", /*sideeffects*/ true); marker = llvm::InlineAsm::get(type, assembly, "", /*sideeffects*/ true);
// If we're at -O1 and above, we don't want to litter the code // If we're at -O1 and above, we don't want to litter the code
// with this marker yet, so leave a breadcrumb for the ARC // with this marker yet, so leave a breadcrumb for the ARC
// optimizer to pick up. // optimizer to pick up.
} else { } else {
llvm::NamedMDNode *metadata = const char *markerKey = "clang.arc.retainAutoreleasedReturnValueMarker";
CGF.CGM.getModule().getOrInsertNamedMetadata( if (!CGF.CGM.getModule().getModuleFlag(markerKey)) {
"clang.arc.retainAutoreleasedReturnValueMarker"); auto *str = llvm::MDString::get(CGF.getLLVMContext(), assembly);
assert(metadata->getNumOperands() <= 1); CGF.CGM.getModule().addModuleFlag(llvm::Module::Error, markerKey, str);
if (metadata->getNumOperands() == 0) {
auto &ctx = CGF.getLLVMContext();
metadata->addOperand(llvm::MDNode::get(ctx,
llvm::MDString::get(ctx, assembly)));
} }
} }
} }
// Call the marker asm if we made one, which we do only at -O0. // Call the marker asm if we made one, which we do only at -O0.
if (marker) if (marker)
CGF.Builder.CreateCall(marker, None, CGF.getBundlesForFunclet(marker)); CGF.Builder.CreateCall(marker, None, CGF.getBundlesForFunclet(marker));
} }
▲ Show 20 Lines • Show All 1,561 Lines • Show Last 20 Lines

test/CodeGenObjC/arc-unsafeclaim.m

Show First 20 Lines • Show All 225 Lines • ▼ Show 20 Lines
// CHECK-NEXT: [[T2:%.*]] = call i8* @llvm.objc.unsafeClaimAutoreleasedReturnValue(i8* [[T1]]) // CHECK-NEXT: [[T2:%.*]] = call i8* @llvm.objc.unsafeClaimAutoreleasedReturnValue(i8* [[T1]])
// CHECK-NEXT: bitcast i8* [[T2]] to [[A]]* // CHECK-NEXT: bitcast i8* [[T2]] to [[A]]*
// CHECK-NEXT: ret void // CHECK-NEXT: ret void
// This is always at the end of the module. // This is always at the end of the module.
// CHECK-OPTIMIZED: !clang.arc.retainAutoreleasedReturnValueMarker = !{!0} // CHECK-OPTIMIZED: !llvm.module.flags = !{!0,
// CHECK-OPTIMIZED: !0 = !{i32 1, !"clang.arc.retainAutoreleasedReturnValueMarker", !"mov{{.*}}marker for objc_retainAutoreleaseReturnValue"}